activity icon indicating copy to clipboard operation
activity copied to clipboard

feat: Add sharing activity for teams

Open susnux opened this issue 1 year ago • 2 comments

This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the files_sharing app.

So if this is merged we can add the required providers in files_sharing.

But one thing to mention: For groups we paginate the members, I did not find a nice way to do this with teams. So maybe @ArtificialOwl can have a look at the member query if there is something to improve performance wise (e.g. pagination?).

susnux avatar Aug 24 '24 17:08 susnux

Activity    Run #2157

Run Properties:  status check failed Failed #2157  •  git commit 77ce8ecacb: feat: Add sharing activity for teams
Project Activity
Branch Review feat/activity-for-team-share
Run status status check failed Failed #2157
Run duration 01m 16s
Commit git commit 77ce8ecacb: feat: Add sharing activity for teams
Committer Ferdinand Thiessen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 8
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has creation activity Test Replay Screenshots
Failed  settings.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

cypress[bot] avatar Aug 24 '24 17:08 cypress[bot]

TIL: protected (Foo&Bar)|Baz $variable does not work with PHP 8.1 but only 8.2 :sweat_smile: (was in the test like: protected (Class&MockObject)|null $variable )

susnux avatar Aug 31 '24 12:08 susnux

/backport to stable31

susnux avatar Jan 23 '25 09:01 susnux