nextcloud
Make container view looks proportional on viewport
On big screen resolution, actual implementation with fixed with looks like an iframe. Make it fluid and align with other items on screen.
Before
After
1 flaky test on run #1584 ↗︎
 0 |
 10 |
 0 |
 0 |
 1 |
Details:
| Make container view looks proportional on viewport | |||
| Project: Activity | Commit: fcd0b5e0b3 |
||
| Status: Passed | Duration: 02:20 💡 | ||
| Started: Jun 10, 2024 5:41 PM | Ended: Jun 10, 2024 5:43 PM | ||
cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has tag activity |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1700 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
With this changes it looks really weird and unreadable on wide screens
Well, we think the same but with current implementation 😄
I think the problem is that the date is floating right of the activity line. If they all (activity and date) were aligned left, i think this would be the best option.
Should this be validated, i could work on that if no one wants to do that.
But, a centered and fixed width doesn't seem the best option IMHO.
But, a centered and fixed width doesn't seem the best option IMHO.
That's why I cc the designers. We use the same layout also in Talk, Announcement Center, and Forms so basically all apps that are "lists" content wise
That's why I cc the designers. We use the same layout also in Talk, Announcement Center, and Forms so basically all apps that are "lists" content wise
Not really the same. Styles are local here and it looks different. For example, we don't have a scroll bar in the middle of content in Talk. It's on the corner.
What about adding a light border between items, so it's easy to connect time and item visually?
For example, we don't have a scroll bar in the middle of content in Talk. It's on the corner.
Yes as I wrote this is a bug currently but the limited width is on design purpose (see also current settings changes).
the scrollbar currently looks not good and should be moved to the very right instead directly next to the centered list.
@solracsf @susnux I've pushed a commit with an intermediate change:
- Scroll bar pushed to the page's edge
- The content is kept on the left (similar to most of the apps like Photos, Settings)
- Using more variables
But I'd make it even wide than in the past
| Before | This PR | Proposal |
|---|---|---|
Width should be 900px. If possible NcAppSettingsSection should be user. Your proposal looks good @ShGKme
If possible NcAppSettingsSection should be user
I'd not use NcAppSettingsSection even if we want a similar design... NcAppSettingsSection by definition has a different purpose. We should not think about activities and other usages while modifying settings components.
We can just use the same design here or introduce a new component.
We should not think about activities and other usages while modifying settings components
Many already do... Do you think that then it would make sense to create an ad hoc component there that all app developers can use?
@marcoambrosini Do you mean NcAppSettingsSection or NcSettingsSection?
Many already do...
Do you have an example?
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Something we need to fix in Settings as well.
@jancborchardt settings should be left aligned as the sidebar is a integral part of the content and on a big screen they get too separated. That is unless we're able to center the navigation too
See the following screenshot as a reference. Granted: it's not great, but think about if the main content was centered
@ShGKme your proposal looks good, but the content should still be visually centered. Especially on bigger screens the left-alignment looks strange.
IMO, the centered content looks strange, as everything else is left aligned... 😄
@jancborchardt @marcoambrosini
This PR is open for quite a long time, and comments from the design team are different.
Are you against this open (settings like, limited width on the left with scroll bar on the right)?
@ShGKme my comment was only concerning settings. I would prefer if there we kept the left alignment
@ShGKme so to clarify, for Activity:
- Limited width as before (can be wider, would be nice if it is the same as in Talk, Text etc)
- Centered as before
- Scrollbar on right edge
Additionally actually: The heading "All activities" (or the others) would also look better if it’s left aligned with the centered content, instead of all the way on the left.