activity icon indicating copy to clipboard operation
activity copied to clipboard
verified publisher icon nextcloud

Username is not shown in Activity comments mention (only "{mention1}")

Open n3ur0m4n opened this issue 1 year ago • 2 comments

Steps to reproduce

  1. Open details for a file (ex. Nextcloud Manual.pdf)
  2. Under the Activity tab add a new comment with @user for mention
  3. In the comments list the user is visible, but under the main Activity tab, the comment show "{mention1}" and the mentioned user is not visible

Expected behaviour

In the main Activity tab, the comment show the mentioned username

Actual behaviour

In the main Activity tab, the comment show "{mention1}"

Server configuration

Operating system: Debian 12 Bookworm

Web server: Nextcloud AIO

Database: PostgreSQL

PHP version: 8.2.18

Nextcloud version: 28.0.4

Where did you install Nextcloud from: Nextcloud AIO Docker

Signing status: No errors have been found.

List of activated apps:

  • activity: 2.20.0
  • admin_audit: 1.18.0
  • app_api: 2.5.0
  • calendar: 4.6.7
  • cloud_federation_api: 1.11.0
  • comments: 1.18.0
  • contacts: 5.5.3
  • contactsinteraction: 1.9.0
  • dashboard: 7.8.0
  • dav: 1.29.1
  • digiviewer: 0.0.1
  • federatedfilesharing: 1.18.0
  • federation: 1.18.0
  • files: 2.0.0
  • files_pdfviewer: 2.9.0
  • files_reminders: 1.1.0
  • files_scripts: 4.0.3
  • files_sharing: 1.20.0
  • files_trashbin: 1.18.0
  • files_versions: 1.21.0
  • groupfolders: 16.0.6
  • impersonate: 1.15.0
  • impianti: 0.0.1
  • logreader: 2.13.0
  • lookup_server_connector: 1.16.0
  • mail: 3.5.7
  • nextcloud-aio: 0.5.0
  • nextcloud_announcements: 1.17.0
  • notes: 4.9.4
  • notifications: 2.16.0
  • notify_push: 0.6.10
  • oauth2: 1.16.3
  • ocs_api_viewer: 1.0.6
  • onlyoffice: 9.1.2
  • password_policy: 1.18.0
  • photos: 2.4.0
  • privacy: 1.12.0
  • provisioning_api: 1.18.0
  • recommendations: 2.0.0
  • related_resources: 1.3.0
  • serverinfo: 1.18.0
  • settings: 1.10.1
  • sgm: 0.0.1
  • sharebymail: 1.18.0
  • support: 1.11.1
  • survey_client: 1.16.0
  • systemtags: 1.18.0
  • text: 3.9.1
  • theming: 2.3.0
  • twofactor_backupcodes: 1.17.0
  • twofactor_totp: 10.0.0-beta.2
  • user_status: 1.8.1
  • viewer: 2.2.0
  • weather_status: 1.8.0
  • workflowengine: 2.10.0

Nextcloud configuration: { "system": { "one-click-instance": true, "one-click-instance.user-limit": 100, "memcache.local": "\OC\Memcache\APCu", "apps_paths": [ { "path": "/var/www/html/apps", "url": "/apps", "writable": false }, { "path": "/var/www/html/custom_apps", "url": "/custom_apps", "writable": true } ], "appsallowlist": false, "check_data_directory_permissions": false, "memcache.distributed": "\OC\Memcache\Redis", "memcache.locking": "\OC\Memcache\Redis", "redis": { "host": "REMOVED SENSITIVE VALUE", "password": "REMOVED SENSITIVE VALUE", "port": 6379 }, "overwritehost": "docstest.digitecno.it", "overwriteprotocol": "https", "passwordsalt": "REMOVED SENSITIVE VALUE", "secret": "REMOVED SENSITIVE VALUE", "trusted_domains": [ "localhost", "docstest.digitecno.it" ], "datadirectory": "REMOVED SENSITIVE VALUE", "dbtype": "pgsql", "version": "28.0.4.1", "overwrite.cli.url": "https://docstest.digitecno.it/", "dbname": "REMOVED SENSITIVE VALUE", "dbhost": "REMOVED SENSITIVE VALUE", "dbport": "", "dbtableprefix": "oc_", "dbuser": "REMOVED SENSITIVE VALUE", "dbpassword": "REMOVED SENSITIVE VALUE", "installed": true, "instanceid": "REMOVED SENSITIVE VALUE", "maintenance": false, "loglevel": "2", "log_type": "file", "logfile": "/var/www/html/data/nextcloud.log", "log_rotate_size": "10485760", "log.condition": { "apps": [ "admin_audit" ] }, "preview_max_x": "2048", "preview_max_y": "2048", "jpeg_quality": "60", "enabledPreviewProviders": { "1": "OC\Preview\Image", "2": "OC\Preview\MarkDown", "3": "OC\Preview\MP3", "4": "OC\Preview\TXT", "5": "OC\Preview\OpenDocument", "6": "OC\Preview\Movie", "7": "OC\Preview\Krita" }, "enable_previews": true, "upgrade.disable-web": true, "mail_smtpmode": "smtp", "trashbin_retention_obligation": "auto, 30", "versions_retention_obligation": "auto, 30", "activity_expire_days": "30", "simpleSignUpLink.shown": false, "share_folder": "/Shared", "one-click-instance.link": "https://nextcloud.com/all-in-one/", "upgrade.cli-upgrade-link": "https://github.com/nextcloud/all-in-one/discussions/2726", "updatedirectory": "/nc-updater", "davstorage.request_timeout": 3600, "htaccess.RewriteBase": "/", "dbpersistent": false, "files_external_allow_create_new_local": false, "trusted_proxies": "REMOVED SENSITIVE VALUE", "default_language": "it", "force_language": "it", "default_locale": "it_IT", "force_locale": "it_IT", "default_phone_region": "it", "mail_smtpsecure": "ssl", "mail_sendmailmode": "smtp", "mail_from_address": "REMOVED SENSITIVE VALUE", "mail_domain": "REMOVED SENSITIVE VALUE", "mail_smtphost": "REMOVED SENSITIVE VALUE", "mail_smtpauth": 1, "mail_smtpport": "465", "mail_smtpname": "REMOVED SENSITIVE VALUE", "mail_smtppassword": "REMOVED SENSITIVE VALUE", "allow_local_remote_servers": true, "data-fingerprint": "dd9aae0d26a8a8c266c8d9eb6b3dc9fd", "updater.release.channel": "stable", "app_install_overwrite": [ "nextcloud-aio", "externalportal" ], "maintenance_window_start": 1, "auth.bruteforce.protection.enabled": true, "ratelimit.protection.enabled": true } }

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... No

Client configuration

Browser: Chrome version 124.0.6367.91 (64 bit)

Operating system: Windows 10

Logs

Nextcloud log (data/nextcloud.log)

{"reqId":"h7U9IPmygcWYp1xks7V4","level":3,"time":"2024-04-10T07:47:06+00:00","remoteAddr":"172.18.0.1","user":"Administrator","app":"onlyoffice","method":"PUT","url":"/apps/onlyoffice/ajax/settings/address","message":"healthcheckRequest on check error","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36","version":"28.0.4.1","exception":{"Exception":"GuzzleHttp\\Exception\\ServerException","Message":"Server error: `GET https://oo1.mydomain.com/healthcheck` resulted in a `503 Service Unavailable` response:\n<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>503 Service Unavailable</title>\n</head><body>\n<h1 (truncated...)\n","Code":503,"Trace":[{"file":"/var/www/html/3rdparty/guzzlehttp/guzzle/src/Middleware.php","line":69,"function":"create","class":"GuzzleHttp\\Exception\\RequestException","type":"::","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":204,"function":"GuzzleHttp\\{closure}","class":"GuzzleHttp\\Middleware","type":"::","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":153,"function":"callHandler","class":"GuzzleHttp\\Promise\\Promise","type":"::","args":[1,"*** sensitive parameters replaced ***","*** sensitive parameters replaced ***"]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/TaskQueue.php","line":48,"function":"GuzzleHttp\\Promise\\{closure}","class":"GuzzleHttp\\Promise\\Promise","type":"::","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":248,"function":"run","class":"GuzzleHttp\\Promise\\TaskQueue","type":"->","args":[true]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":224,"function":"invokeWaitFn","class":"GuzzleHttp\\Promise\\Promise","type":"->","args":[]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":269,"function":"waitIfPending","class":"GuzzleHttp\\Promise\\Promise","type":"->","args":[]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":226,"function":"invokeWaitList","class":"GuzzleHttp\\Promise\\Promise","type":"->","args":[]},{"file":"/var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php","line":62,"function":"waitIfPending","class":"GuzzleHttp\\Promise\\Promise","type":"->","args":[]},{"file":"/var/www/html/3rdparty/guzzlehttp/guzzle/src/Client.php","line":187,"function":"wait","class":"GuzzleHttp\\Promise\\Promise","type":"->","args":[]},

Browser log

Failed to load resource: the server responded with a status of 404 () /.well-known/nodeinfo:1

Failed to load resource: the server responded with a status of 404 () /.well-known/webfinger:1

image

image

n3ur0m4n avatar Apr 30 '24 14:04 n3ur0m4n

Same for multiple mentions. Result is "{mention1} {mention2} text"

Using NC v29.0.3

rakekniven avatar Jul 15 '24 09:07 rakekniven

Confirmed. Thanks for reporting!

I suspect the issue in in Server, since the Provider for comment activity is implemented there.

If someone wants to try to determine the source of this bug, here's where I'd look:

https://github.com/nextcloud/server/blob/fbbc10466b79caea0b9d1f718d4abdd021df241c/apps/comments/lib/Activity/Provider.php#L161

And the Activity Provider docs:

https://github.com/nextcloud/activity/blob/4d8ae09f8af4beea9a9c0d1c2faeb454a94240e1/docs/provider.md

joshtrichards avatar Aug 07 '24 01:08 joshtrichards