Exclude specified users from activity expiration

[akhil1508]

• On my nextcloud setup, I want to keep activities only for a few months for all users
• However, the admin activities should be there forever as they provide a great way of keeping track of admin actions and also user actions that set the activity user as admin

[akhil1508]

Could you take a look at the CI errors?

@artonge Apologies, I didn't run PHP CS Fixer; should be good now

[akhil1508]

@artonge I don't understand

Error: lib/AppInfo/Application.php:114:11: TooFewArguments: Too few arguments for OCA\Activity\Data::__construct - expecting config to be passed (see https://psalm.dev/025)

As I didn't change lib/AppInfo/Application.php

[miaulalala]

@artonge I don't understand

Error: lib/AppInfo/Application.php:114:11: TooFewArguments: Too few arguments for OCA\Activity\Data::__construct - expecting config to be passed (see psalm.dev/025)

As I didn't change lib/AppInfo/Application.php

You need to register the IConfig injection to https://github.com/nextcloud/activity/blob/59e65d4bce3d3e22548191185fb3a307452f58d5/lib/AppInfo/Application.php#L113-L119

		$context->registerService(Data::class, function (ContainerInterface $c) {
			return new Data(
				$c->get(IManager::class),
				$c->get('ActivityConnectionAdapter'),
				$c->get(LoggerInterface::class),
				$c->get(IConfig::class),
			);
		});

[artonge]

Could you also squash your commits into one?

[akhil1508]

Could you also squash your commits into one?

@artonge done

[miaulalala]

Tests need the new constructor properties :)

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[akhil1508]

Tests need the new constructor properties :)

@miaulalala Done. I will squash again and fix commit push after final approval(s) to avoid doing it many times.

[artonge]

Still one minor lint error

[akhil1508]

Still one minor lint error

@artonge Fixed

[artonge]

@artonge Fixed

Almost :)

[miaulalala]

akhil1508 do you still wanna work on this? Otherwise I'd take over :)

[akhil1508]

do you still wanna work on this? Otherwise I'd take over :)

@miaulalala Please take over, I might not be able to work on this for a while :|

[miaulalala]

Superseded by https://github.com/nextcloud/activity/pull/1635

[miaulalala]

Thanks a lot for your work on this @akhil1508 !