nextcloud
fix issues with Void return type due to rxjs map operator null checks
This one will still die (in most cases my code comes across this line...):
https://github.com/nextcloud/Android-SingleSignOn/blob/95ced6841da33239e699c0033f88582b5bcb15eb/src/main/java/com/nextcloud/android/sso/api/NextcloudRetrofitServiceMethod.java#L190
Codacy
32Lint
| Type | master | PR |
| Warnings | 3 | 3 |
| Errors | 0 | 0 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 2 |
| Correctness Warnings | 15 |
| Internationalization Warnings | 2 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 5 |
| Security Warnings | 5 |
| Dodgy code Warnings | 9 |
| Total | 41 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 2 |
| Correctness Warnings | 17 |
| Internationalization Warnings | 2 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 5 |
| Security Warnings | 5 |
| Dodgy code Warnings | 10 |
| Total | 44 |
@desperateCoder Did you have a chance to fight the unit tests yet? 🙈 Or do you prefer that we close this pr here and create a new issue instead?
@David-Development Actually not, since @stefan-niedermann keeps throwing feature requests at my head... If you say you really need my help, I'll see what I can do, although I hate testing 😅
@David-Development @desperateCoder @stefan-niedermann I guess this PR is obsolete given the lately merged new approach brought in by Stefan via #542
