Android-SingleSignOn icon indicating copy to clipboard operation
Android-SingleSignOn copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

fix issues with Void return type due to rxjs map operator null checks

Open David-Development opened this issue 5 years ago • 4 comments

David-Development avatar Aug 08 '20 17:08 David-Development

This one will still die (in most cases my code comes across this line...):

https://github.com/nextcloud/Android-SingleSignOn/blob/95ced6841da33239e699c0033f88582b5bcb15eb/src/main/java/com/nextcloud/android/sso/api/NextcloudRetrofitServiceMethod.java#L190

desperateCoder avatar Aug 09 '20 12:08 desperateCoder

Codacy

32

Lint

TypemasterPR
Warnings33
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings2
Correctness Warnings15
Internationalization Warnings2
Multithreaded correctness Warnings3
Performance Warnings5
Security Warnings5
Dodgy code Warnings9
Total41

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings2
Correctness Warnings17
Internationalization Warnings2
Multithreaded correctness Warnings3
Performance Warnings5
Security Warnings5
Dodgy code Warnings10
Total44

nextcloud-android-bot avatar Aug 09 '20 18:08 nextcloud-android-bot

@desperateCoder Did you have a chance to fight the unit tests yet? 🙈 Or do you prefer that we close this pr here and create a new issue instead?

David-Development avatar Sep 04 '20 17:09 David-Development

@David-Development Actually not, since @stefan-niedermann keeps throwing feature requests at my head... If you say you really need my help, I'll see what I can do, although I hate testing 😅

desperateCoder avatar Sep 04 '20 17:09 desperateCoder

@David-Development @desperateCoder @stefan-niedermann I guess this PR is obsolete given the lately merged new approach brought in by Stefan via #542

AndyScherzinger avatar Jan 19 '24 17:01 AndyScherzinger

obsolete from my PoV

stefan-niedermann avatar Jan 19 '24 17:01 stefan-niedermann