[DRAFT] feat: add NcFormListBox
βοΈ Resolves
- Ref: https://github.com/nextcloud/mail/issues/11910
I'm very unsure with the approach in this PR:
- It indirectly overrides
<NcListItem>styles...- Should it be internally modified in the
NcListItembased onisInFormBoxinstead? - Should it be just a new component like
McFormListBoxItem?
- Should it be internally modified in the
- Should it be in any way related to the
NcFormBox?- We can make it optionally
uland override styles there instead of a new container
- We can make it optionally
πΌοΈ Screenshots
π Checklist
- [x] βοΈ Tests are included or are not applicable
- [x] π Component documentation has been extended, updated or is not applicable
- [x] 2οΈβ£ Backport to
stable8for maintained Vue 2 version or not applicable
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.11%. Comparing base (8e6c2a6) to head (1957223).
:warning: Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7889 +/- ##
=======================================
Coverage 52.11% 52.11%
=======================================
Files 100 100
Lines 3170 3170
Branches 872 872
=======================================
Hits 1652 1652
Misses 1271 1271
Partials 247 247
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
So that I understand: Currently, there is no dedicated "list" component, only the standard <ul> tag, correct?
And the only thing this does is add separators between list items, correct?
So that I understand: Currently, there is no dedicated "list" component, only the standard
<ul>tag, correct?
No, this PR adds a new dedicated NcFormListBox component as an alternative to NcFormBox for lists.
And the only thing this does is add separators between list items, correct?
No, it also adjusts the padding of the existing NcListItem to match the other form element labels.
Ok, well regarding https://github.com/nextcloud-libraries/nextcloud-vue/issues/7900#issuecomment-3558424085, I'm not sure some of these should even be list items thenβ¦