nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[DRAFT] feat: add NcFormListBox

Open ShGKme opened this issue 1 month ago β€’ 4 comments

β˜‘οΈ Resolves

  • Ref: https://github.com/nextcloud/mail/issues/11910

I'm very unsure with the approach in this PR:

  1. It indirectly overrides <NcListItem> styles...
    • Should it be internally modified in the NcListItem based on isInFormBox instead?
    • Should it be just a new component like McFormListBoxItem?
  2. Should it be in any way related to the NcFormBox?
    • We can make it optionally ul and override styles there instead of a new container

πŸ–ΌοΈ Screenshots

image

🏁 Checklist

  • [x] ⛑️ Tests are included or are not applicable
  • [x] πŸ“˜ Component documentation has been extended, updated or is not applicable
  • [x] 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

ShGKme avatar Nov 19 '25 15:11 ShGKme

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 52.11%. Comparing base (8e6c2a6) to head (1957223). :warning: Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7889   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files         100      100           
  Lines        3170     3170           
  Branches      872      872           
=======================================
  Hits         1652     1652           
  Misses       1271     1271           
  Partials      247      247           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 19 '25 15:11 codecov[bot]

So that I understand: Currently, there is no dedicated "list" component, only the standard <ul> tag, correct?

And the only thing this does is add separators between list items, correct?

kra-mo avatar Nov 20 '25 14:11 kra-mo

So that I understand: Currently, there is no dedicated "list" component, only the standard <ul> tag, correct?

No, this PR adds a new dedicated NcFormListBox component as an alternative to NcFormBox for lists.

And the only thing this does is add separators between list items, correct?

No, it also adjusts the padding of the existing NcListItem to match the other form element labels.

ShGKme avatar Nov 20 '25 14:11 ShGKme

Ok, well regarding https://github.com/nextcloud-libraries/nextcloud-vue/issues/7900#issuecomment-3558424085, I'm not sure some of these should even be list items then…

kra-mo avatar Nov 20 '25 15:11 kra-mo