nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

chore(deps): bump @vuepic/vue-datepicker from 11.0.2 to 12.0.1

Open dependabot[bot] opened this issue 1 month ago • 13 comments

Bumps @vuepic/vue-datepicker from 11.0.2 to 12.0.1.

Release notes

Sourced from @​vuepic/vue-datepicker's releases.

v12.0.1

🐛 Bug Fixes

  • Fixed issue where text-input format pattern not propely inheriting default value from formats (#1172)
  • Fixed issue where selecting more that one date in multi-dates mode throws an error (#1173)

v11.0.3

🐛 Bug Fixes

v12.0.0

⚠️ Breaking changes

This release includes a lot of internal refactor and a lot of breaking changes.

Please take a look at the migration guide

🚀 Features

  • Added option to add calendard instance in setMonthYear exposed function (#1120)
  • Added option to hide menu arrow (floating prop) (#1089)
  • Added option to change inputmode (#1149)
  • Added option to set custom input id (input-attrs prop) (#1163)
  • Added @invalid event that propagates oninvalid from the input field (#1127)
  • Added input masking on text-input alpha stage , tnx to @​apsisxcoder (#1131)
  • Added support for rounding the value on now button (action-row prop) (#1138)

🐛 Bug Fixes

  • Fixed issue where time values in the overlay are not reacting to v-model change (#1108)
  • Fixed issue with time increment when picking from non-DST to DST date (#1112)
  • Fixed issue with being unable to use auto-apply when partialRange is enabled (#1113)
  • Fixed issue where Increasing calendar width makes the inline time picker not centered (#1117)
  • Fixed issue where maxRange and minRange are not working in year-picker mode (#1123)
  • Fixed issue where mobile swipe causes an unwanted selection of dates in the calendar (#1124, #1169)
  • Fixed issue where auto-apply closes the picker when using flow with range (#1125)
  • Fixed issue where start-date is not working in quarter-picker mode (#1133)
  • Fixed issue where events range-start and range-end are not emitted when the time is updated (fixes #1142)
  • Fixed positioning issue on smaller screens with preset-dates enabled (#1144)
  • Fixed issue with wrong week numbers from 2027 (#1147)
  • Fixed isue where auto-apply not selecting range in quarter-picker mode (#1166)

... (truncated)

Commits
  • 53b37d0 docs: Update docs build
  • 0f224fd chore: Resolve types
  • 2f869f1 chore: Bump version
  • c9125d7 docs: Try to resolve hydration issue on demo components
  • 6f2b19b fix: text-input prop using default patterns instead of format default (fixe...
  • 042b968 fix: Selecting more than one date in multi-dates throws an error (fixes #1173)
  • b6cf6ff docs: Add note for start-time in migration guide (fixes #1170)
  • c270fe1 docs: Fix examples for disabled-dates and allowed-dates (fixes #1171)
  • 8680cdf chore: Update readme
  • a39f8d7 chore: Update sonar workflow
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Nov 04 '25 07:11 dependabot[bot]

@dependabot rebase

susnux avatar Nov 04 '25 12:11 susnux

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (main@7020545). Learn more about missing BASE report. :warning: Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7767   +/-   ##
=======================================
  Coverage        ?   51.58%           
=======================================
  Files           ?       96           
  Lines           ?     3148           
  Branches        ?      865           
=======================================
  Hits            ?     1624           
  Misses          ?     1276           
  Partials        ?      248           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 04 '25 12:11 codecov[bot]

A newer version of @​vuepic/vue-datepicker exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar Nov 06 '25 07:11 dependabot[bot]

Item Initial Size Async Size Assets Size Total Size
components/NcDateTimePicker (before) 282.93 kb - 58.83 kb 341.76 kb
components/NcDateTimePicker (after) 887.21 kb - 58.90 kb 946.11 kb
diff 🔺+214% - ~ 🔺+177%

😬😬😬

ShGKme avatar Nov 06 '25 19:11 ShGKme

Some breaking changes seem to be missing.

resolved that part and size should also be resolved.

susnux avatar Nov 06 '25 20:11 susnux

Tested in both Vite and Webpack apps?

ShGKme avatar Nov 07 '25 10:11 ShGKme

Tested in both Vite and Webpack apps?

Currently only tested it in vite apps

susnux avatar Nov 07 '25 11:11 susnux

Pushed a fix, should now work as expected in both app classes.

susnux avatar Nov 07 '25 13:11 susnux

Better than with bundling everything. But still quite large. I guess, there is notthing we can do with it.

Item Initial Size Async Size Assets Size Total Size
components/NcDateTimePicker (before) 282.93 kb - 58.83 kb 341.76 kb
components/NcDateTimePicker (after) 315.34 kb 1840.26 kb 58.90 kb 2214.50 kb
diff 🔺+12% - ~ 🔺+550%

ShGKme avatar Nov 10 '25 20:11 ShGKme

One problem I found. With default Vite and some Webpack/RSPack configs, every locale as well as its shared utils (3 modules) are new chunks. It increases number of chunks in an app significantly. And some locales needs ~4 HTTP requests.

It is solvable by local bundler config, for example, by setting a new cacheGroup.

However, because these chunks are just mixed with others, it's a bit hard, requires regexp to find very specific files in node_modules.

Can we:

  1. Either not bundle these modules and keep it in data-fns
  2. Or build them into a split folder in nextcloud-vue with a predictable path.

ShGKme avatar Nov 10 '25 20:11 ShGKme

every locale as well as its shared utils (3 modules) are new chunks. It increases number of chunks in an app significantly.

Well but thats a good thing here if every locale is its own chunk then the user only loads what needed - the locale will mostly not change so only the needed chunk is loaded. The number of chunks is currently not a performance issue but the size of them is the current real performance issue.

Nevertheless I currently check if we can avoid date-fn locales here in general as we already pass in most of the formatting our self.

susnux avatar Nov 11 '25 17:11 susnux

Well but thats a good thing here if every locale is its own chunk then the user only loads what needed - the locale will mostly not change so only the needed chunk is loaded. The number of chunks is currently not a performance issue but the size of them is the current real performance issue.

In general, it is also an issue. Having too many nano chunks instead of web-optimised is one of the reasons Rollup to be developed.

I did not propose to have no chunk, but only to have 1 chunk per locale. It doesn't make sense to load 4 chunks just to have a single locale in a date-time picker.

Anyway, that is not the main, but only an additional problem.

The main problem is that date-fns locales now live not separately in date-fns/locale, but in @nextcloud/vue/dist/chunks mixed with all the other chunks.

This makes it quite complicated to configure any date-fns specific bundling for the library user.

They are different from other "classic" chunks and may require specific handling.

For example, we never need to have more than 1 locale. It is always a single locale. Thus it doesn't make sense to merge locale chunks into other modules even if they are too small, unlike normal chunks.

ShGKme avatar Nov 11 '25 20:11 ShGKme

Briefly, I'd prefer:

  • Either keep date-fns locales in the date-fns and not distribute it as @nextcloud/vue own chunks
  • Or split them at least structurally so a developer can configure locale handling on the app side

ShGKme avatar Nov 11 '25 20:11 ShGKme