nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

feat(NcFilePicker): add picker component to select local files

Open susnux opened this issue 6 months ago • 4 comments

  • related to https://github.com/nextcloud-libraries/nextcloud-upload/issues/1809

☑️ Resolves

This can be used e.g. to upload files, for example in the forms app but also for the files or photos app. It is more universal than the upload picker from nc-upload as it is not bound to webdav uploader.

Just to clarify: This is NOT the uploader. The idea here is that this is just a plain file picker (styled and enhanced input[type=file]. The use case are apps which have their own way of handling uploads - like forms - or if you directly process files in the browser.

There will be a follow up with NcUploader or NcUploadPicker (?) which will be the migrated component from @nextcloud/upload and will be based on this component.

🏁 Checklist

  • [x] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable
  • [ ] 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

susnux avatar Jun 26 '25 10:06 susnux

@susnux is there anything you want to change here? I think you mentioned it at a meeting.

ShGKme avatar Oct 01 '25 20:10 ShGKme

is there anything you want to change here? I think you mentioned it at a meeting.

Yes will work on it

susnux avatar Nov 04 '25 11:11 susnux

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 52.11%. Comparing base (8f99087) to head (be16ff5). :warning: Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7097      +/-   ##
==========================================
+ Coverage   51.78%   52.11%   +0.33%     
==========================================
  Files          98      100       +2     
  Lines        3171     3170       -1     
  Branches      874      873       -1     
==========================================
+ Hits         1642     1652      +10     
+ Misses       1279     1271       -8     
+ Partials      250      247       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 14 '25 16:11 codecov[bot]

Just to clarify: This is NOT the uploader. The idea here is that this is just a plain file picker (styled and enhanced input[type=file]. The use case are apps which have their own way of handling uploads - like forms - or if you directly process files in the browser.

There will be a follow up with NcUploader or NcUploadPicker (?) which will be the migrated component from @nextcloud/upload and will be based on this component.

Current state of this PR is: I will add proper tests for this new component. As soon as that is done I will set the state to "3. to review" and mark it as "ready for review".

susnux avatar Nov 14 '25 16:11 susnux