refactor(NcColorPicker): migrate component to Typescript
☑️ Resolves
- for #841
- deprecate
update:openits a duplicate ofcloseand there is not even aopenprop - migrate to Typescript and script-setup
🏁 Checklist
- [ ] ⛑️ Tests are included or are not applicable
- [x] 📘 Component documentation has been extended, updated or is not applicable
- [x] 2️⃣ Backport to
stable8for maintained Vue 2 version or not applicable
/backport 74d89c27dcd948d595dc8eef6820ac3eadd8cdc2 to stable8
- deprecate
update:openits a duplicate ofcloseand there is not even aopenprop
Maybe instead add the open prop to control the picker state and manually open it?
update:open is not a complete duplicate of the close.
<NcColorPicker @close="handleClose" />
vs
<NcColorPicker @update:open="$event === false && handleClose()" />
@ShGKme well it is only emitted with false (and not used anywhere in our org).
Would agree with the open prop, but I can not think of a use case and would say its better to add when there is a need.
(or to make it consistent with other pickers, but the others also do not have an open state).
The backport to stable8 failed. Please do this backport manually.
# Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/7080/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 74d89c27
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7080/stable8
Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress fatal: cherry-pick failed
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.
/backport d6f7c6549fcb031131a6b11b0c3fc1cad9ded766 to stable8
/backport 79dc797189b5569bb7af62c313f59182d4ae0491 to stable8