nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

refactor(NcColorPicker): migrate component to Typescript

Open susnux opened this issue 6 months ago • 3 comments

☑️ Resolves

  • for #841
  1. deprecate update:open its a duplicate of close and there is not even a open prop
  2. migrate to Typescript and script-setup

🏁 Checklist

  • [ ] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable
  • [x] 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

susnux avatar Jun 23 '25 18:06 susnux

/backport 74d89c27dcd948d595dc8eef6820ac3eadd8cdc2 to stable8

susnux avatar Jun 23 '25 18:06 susnux

  1. deprecate update:open its a duplicate of close and there is not even a open prop

Maybe instead add the open prop to control the picker state and manually open it?

update:open is not a complete duplicate of the close.

<NcColorPicker @close="handleClose" />
vs
<NcColorPicker @update:open="$event === false && handleClose()" />

ShGKme avatar Jun 24 '25 09:06 ShGKme

@ShGKme well it is only emitted with false (and not used anywhere in our org). Would agree with the open prop, but I can not think of a use case and would say its better to add when there is a need. (or to make it consistent with other pickers, but the others also do not have an open state).

susnux avatar Jun 24 '25 10:06 susnux

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7080/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 74d89c27

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7080/stable8

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] avatar Jun 25 '25 10:06 backportbot[bot]

/backport d6f7c6549fcb031131a6b11b0c3fc1cad9ded766 to stable8

susnux avatar Jun 25 '25 13:06 susnux

/backport 79dc797189b5569bb7af62c313f59182d4ae0491 to stable8

susnux avatar Sep 20 '25 15:09 susnux