nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

fix(NcButton): re-export types

Open ShGKme opened this issue 7 months ago • 5 comments

☑️ Resolves

  • Fix https://github.com/nextcloud-libraries/nextcloud-vue/issues/6870

🏁 Checklist

  • [x] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable
  • [ ] 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

ShGKme avatar May 02 '25 14:05 ShGKme

Affects much more components

This is the only component with type export

ShGKme avatar May 02 '25 14:05 ShGKme

@skjnldsv Does it work for you? I am unsure this is the problem you had :)

ShGKme avatar May 02 '25 14:05 ShGKme

@skjnldsv ?

ShGKme avatar May 14 '25 20:05 ShGKme

I stopped using the type, cannot tell 🙈

skjnldsv avatar May 14 '25 21:05 skjnldsv

converted to draft until we decided if this is the way we want it to be, ref: https://github.com/nextcloud-libraries/nextcloud-vue/issues/6870#issuecomment-2909748056

susnux avatar May 26 '25 19:05 susnux

Reopen if we decide the other way around but otherwise lets keep types in component entry points

susnux avatar Aug 21 '25 17:08 susnux