nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

chore(NcAppSidebar): correctly define and document exposed CSS variables

Open ShGKme opened this issue 1 year ago • 8 comments

☑️ Resolves

  • Although AppSidebar's and AppNavigation's toggle button paddings have the same value, they don't have a single source
  • Replaced using navigation SCSS variable in the sidebar with the direct value
  • Fixed docs for --app-sidebar-offset
  • Added "Exposed CSS Variables" docs section

🖼️ Screenshots

image

🏁 Checklist

  • [x] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable
  • [x] 3️⃣ Backport to next requested with a Vue 3 upgrade

ShGKme avatar Jul 24 '24 12:07 ShGKme

Thank you this is a very nice thing :)

susnux avatar Jul 24 '24 12:07 susnux

Force pushed just a commit message typo fix

ShGKme avatar Jul 24 '24 12:07 ShGKme

@ShGKme you need to update cypress snapshots :see_no_evil:

susnux avatar Jul 24 '24 13:07 susnux

@ShGKme you need to update cypress snapshots 🙈

I changed nothing 🥲

ShGKme avatar Jul 24 '24 14:07 ShGKme

Will do so later today

ShGKme avatar Jul 24 '24 14:07 ShGKme

I changed nothing 🥲

Maybe a padding or something else moved like 1px?

susnux avatar Jul 24 '24 14:07 susnux

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

ShGKme avatar Jul 24 '24 15:07 ShGKme

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

Put it into NcContent in the cypress tests? For the PlayWright migration this was done :sweat_smile:

susnux avatar Jul 24 '24 15:07 susnux

Rebased onto main

susnux avatar Jul 09 '25 19:07 susnux