chore(NcAppSidebar): correctly define and document exposed CSS variables
☑️ Resolves
- Although AppSidebar's and AppNavigation's toggle button paddings have the same value, they don't have a single source
- Replaced using navigation SCSS variable in the sidebar with the direct value
- Fixed docs for
--app-sidebar-offset - Added "Exposed CSS Variables" docs section
🖼️ Screenshots
🏁 Checklist
- [x] ⛑️ Tests are included or are not applicable
- [x] 📘 Component documentation has been extended, updated or is not applicable
- [x] 3️⃣ Backport to
nextrequested with a Vue 3 upgrade
Thank you this is a very nice thing :)
Force pushed just a commit message typo fix
@ShGKme you need to update cypress snapshots :see_no_evil:
@ShGKme you need to update cypress snapshots 🙈
I changed nothing 🥲
Will do so later today
I changed nothing 🥲
Maybe a padding or something else moved like 1px?
Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.
Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.
Put it into NcContent in the cypress tests? For the PlayWright migration this was done :sweat_smile:
Rebased onto main