nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

Add bounce effect to sidebars' animations

Open marcoambrosini opened this issue 1 year ago • 6 comments

  • [ ] Add variables and fallbacks
  • [x] Fix issue with right sidebar not "bouncing" on narrow screens

marcoambrosini avatar May 16 '24 14:05 marcoambrosini

@ShGKme @susnux I would need some help with this:

For some reason, for the right sidebar the transition works only below the breakpoint where the margins of the app content disappear. If the window is bigger than that, the bounce animation does not work. Could you please look into this together?

marcoambrosini avatar May 16 '24 14:05 marcoambrosini

For some reason, for the right sidebar the transition works only below the breakpoint where the margins of the app content disappear. If the window is bigger than that, the bounce animation does not work. Could you please look into this together?

  • To be fixed in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5608

The animated property isn't width but max-width. But max-width can be bigger than width.

For example, on 1440px wide screen, width is 27vw = 400px while max-width: 500px.

So in the beginning (ending) of the animation, it changes max-width to 500px -> 400px while the actual width stays 400px. It makes visual delay and breaks the easing function params.

ShGKme avatar May 17 '24 20:05 ShGKme

@marcoambrosini Did it help for you?

ShGKme avatar May 20 '24 10:05 ShGKme

@ShGKme It seems that the sidebar doesn't close anymore after https://github.com/nextcloud-libraries/nextcloud-vue/pull/5608 I'm trying to find out what's going on

marcoambrosini avatar May 20 '24 10:05 marcoambrosini

Waiting for this to be closed https://github.com/nextcloud-libraries/nextcloud-vue/issues/5623

marcoambrosini avatar May 22 '24 09:05 marcoambrosini

Waiting for this to be closed https://github.com/nextcloud-libraries/nextcloud-vue/issues/5623

is resolved

susnux avatar Apr 01 '25 19:04 susnux