nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

NcAppNavigation in mobile state blocks interacting with dialogs

Open Antreesy opened this issue 1 year ago • 4 comments

When it's in mobile state, focus trap is attached to toggle, and thus any open dialog would be inaccessible from keyboard (not saying that I couldn't type in TextField)

image

ncdialog-focustrap

Any known PR, where this regression could come from?

Originally posted by @Antreesy in https://github.com/nextcloud-libraries/nextcloud-vue/issues/5335#issuecomment-1985959176

Antreesy avatar Mar 08 '24 16:03 Antreesy

The issue is also impacting cospend app. It happens with width < 512px. https://github.com/julien-nc/cospend-nc/issues/248

When clicking on the textarea, the focus is attached to the logo link instead of the textarea when width < 512px.

width 511px:

2024-03-21_03-41-46-939_brave

width 512px:

2024-03-21_03-46-53-560_brave

adripo avatar Mar 21 '24 02:03 adripo

Not sure if the app navigation is the problem, as the same issue happens on the sidebar

susnux avatar May 11 '24 14:05 susnux

My assumption is that any mounted/visible element with focus trap may affect it

Antreesy avatar May 11 '24 15:05 Antreesy

Yes see #5584 for the sidebar.

Another option would be to watch the style property of a component and when display: none is set (v-show: false) then remove the focus trap.

susnux avatar May 11 '24 15:05 susnux