nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[NcActions] Inconsistent icon position

Open ShGKme opened this issue 1 year ago • 11 comments

#icon slot is centered and icon-class is on top.

image

ShGKme avatar Feb 21 '24 21:02 ShGKme

@nextcloud-libraries/designers what position is preferred?

ShGKme avatar Feb 21 '24 21:02 ShGKme

I prefer the second one (vertically centered). That said, IMO, it's not a bug.

Jerome-Herbinet avatar Feb 22 '24 07:02 Jerome-Herbinet

Although I also prefer center aligned when there's only one line of text, I think that the better strategy for this component is to top align given that it accepts multiple lines of text. When there are multiple lines of text, the icon gets further and further away from the title.

Here's a real world example of top aligned. @ShGKme note that in your screenshot the icon is not properly centered with the text.

Screenshot 2024-02-22 at 09 59 12

marcoambrosini avatar Feb 22 '24 09:02 marcoambrosini

Yep, confirming what @marcoambrosini said, it's better to have it aligned to the top, with the heading. Otherwise the icon is basically at an arbitrary position.

jancborchardt avatar Feb 28 '24 10:02 jancborchardt