nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

fix(NcActions): check slot content only during the rendering

Open ShGKme opened this issue 1 year ago • 1 comments

☑️ Resolves

  • Alternative of https://github.com/nextcloud-libraries/nextcloud-vue/pull/5196
  • Fix #…

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • [ ] ...

🏁 Checklist

  • [ ] ⛑️ Tests are included or are not applicable
  • [ ] 📘 Component documentation has been extended, updated or is not applicable

ShGKme avatar Jan 31 '24 18:01 ShGKme

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (83d844d) 39.34% compared to head (eee1852) 39.39%.

Files Patch % Lines
src/components/NcActionLink/NcActionLink.vue 0.00% 2 Missing :warning:
src/components/NcActions/NcActions.vue 33.33% 0 Missing and 2 partials :warning:
src/components/NcActionRouter/NcActionRouter.vue 0.00% 1 Missing :warning:
src/mixins/actionGlobal.js 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
+ Coverage   39.34%   39.39%   +0.04%     
==========================================
  Files         139      139              
  Lines        3688     3691       +3     
  Branches      810      810              
==========================================
+ Hits         1451     1454       +3     
  Misses       2021     2021              
  Partials      216      216              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 18:01 codecov[bot]