nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

enh(NcAppNavigationItem): Allow to pass SVG or path as icon property

Open susnux opened this issue 2 years ago • 2 comments

☑️ Resolves

Not only allow icon classes (somewhat deprecated) but also SVG or SVG paths as icon property.

🖼️ Screenshots

Screenshot 2023-11-29 at 15-34-46 Nextcloud Vue Style Guide

🏁 Checklist

  • [x] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable

susnux avatar Nov 29 '23 14:11 susnux

Is it required for a specific place? Why not use the icon slot?

ShGKme avatar Nov 29 '23 17:11 ShGKme

Why not use the icon slot?

I can do so. Whats then the plan with the icon props? Should we deprecate them as icon classes are deprecated and just recommend using icon slots with svg wrapper. Or should be move them to SVG support?

susnux avatar Dec 06 '23 18:12 susnux