nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

Treat 1024px width as not mobile everywhere

Open max-nextcloud opened this issue 2 years ago • 3 comments

In some places we treat a screen of width 1024 as mobile - in others it's the smallest that's not treated as mobile. Following up on #3768 also change the following css styles to not apply to 1024px / or 512 px. respectively:

https://github.com/nextcloud/nextcloud-vue/blob/8342cda8a128da49b421bd24edf3b1c928a152c6/src/components/NcAppNavigation/NcAppNavigation.vue#L189-L196 and https://github.com/nextcloud/nextcloud-vue/blob/c80a585a2eef2bd1057917271c1ce0d2dabd02a6/src/components/NcModal/NcModal.vue#L936 and https://github.com/nextcloud/nextcloud-vue/blob/c53599ed09b68d1e00c134c0fc2405848c162548/src/components/NcAppSidebar/NcAppSidebar.vue#L881

Originally posted by @raimund-schluessler in https://github.com/nextcloud/nextcloud-vue/issues/3768#issuecomment-1432984944

max-nextcloud avatar Feb 17 '23 14:02 max-nextcloud

I would like to contribute on this

Girishbari avatar Feb 17 '23 17:02 Girishbari

@Girishbari that's great news! If you need any further information feel free to ping me.

max-nextcloud avatar Feb 17 '23 17:02 max-nextcloud

can you give screenshot

Palakyadav30 avatar Aug 23 '23 17:08 Palakyadav30