nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

Make sidebar buttons pixel perfect

Open CarlSchwan opened this issue 2 years ago • 9 comments

Tested in talk, calendar and files

Before After
image image

CarlSchwan avatar Nov 25 '22 11:11 CarlSchwan

I think this should be a css variable so that we can easily adjust the spacing of the inner app-content too

How is it looking in photos then?

skjnldsv avatar Nov 25 '22 11:11 skjnldsv

This is how photo looks like:

image

CarlSchwan avatar Nov 28 '22 09:11 CarlSchwan

Cypress needs an update

skjnldsv avatar Nov 29 '22 07:11 skjnldsv

This is how photo looks like:

You have viewer opened on your screenshot. There is a header in photos too, i'd like to see the alignment :) Capture d’écran_2022-11-29_08-51-20

skjnldsv avatar Nov 29 '22 07:11 skjnldsv

With photo image

Looks alligned to me ;)

It took me a while how to figure out how to make the sidebar appear...

CarlSchwan avatar Dec 01 '22 11:12 CarlSchwan

cypress updated :)

CarlSchwan avatar Dec 01 '22 11:12 CarlSchwan

I think this should be a css variable so that we can easily adjust the spacing of the inner app-content too

How is it looking in photos then?

I think this is still valid though :shrug: So we can use the same variable for photos alignments or Talk :)

skjnldsv avatar Dec 01 '22 16:12 skjnldsv

there is this atm https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppContent/NcAppContent.vue#L341

marcoambrosini avatar Dec 01 '22 16:12 marcoambrosini

there is this atm master/src/components/NcAppContent/NcAppContent.vue#L341

Then this should be used! Btw, is this documented anywhere? Are you using it in Talk?

skjnldsv avatar Dec 02 '22 13:12 skjnldsv