nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud-libraries

Allow use of any trailing material design icon in TextField

Open Pytal opened this issue 3 years ago • 8 comments

Preserve the ergonomics of being able to simply pass "close" or "arrowRight" strings for the trailing icon while expanding allowed use cases

Pytal avatar Sep 30 '22 19:09 Pytal

For some reason this affects the NcAppSidebar cypress tests

Pytal avatar Sep 30 '22 22:09 Pytal

Can we mark trailingButtonIcon as deprecated so we can remove it in a few major bump?

artonge avatar Oct 01 '22 07:10 artonge

For some reason this affects the NcAppSidebar cypress tests

No idea why, but the color of the favorite icon changed. Before: NcAppSidebar vue-subtitle_null-starred_true-compact_true-header_image-secondary_button-editable_false-base

After: NcAppSidebar vue-subtitle_null-starred_true-compact_true-header_image-secondary_button-editable_false-actual

raimund-schluessler avatar Oct 01 '22 09:10 raimund-schluessler

Could it be that a change in server now makes the cypress tests fail due to https://github.com/nextcloud/nextcloud-vue/pull/3139? The cypress tests for a PR that got merged yesterday without issues (https://github.com/nextcloud/nextcloud-vue/actions/runs/3159764008/jobs/5152100405) now also fail. I think it is less than ideal that external changes break the tests for this repository without interaction. There is no way of catching or debugging this.

@skjnldsv @marcoambrosini

raimund-schluessler avatar Oct 01 '22 09:10 raimund-schluessler

I created a separate issue for this https://github.com/nextcloud/nextcloud-vue/issues/3325

raimund-schluessler avatar Oct 01 '22 09:10 raimund-schluessler

@Pytal We deliberately limited the functionality there to control the design a bit more. What trailing icon do you need there?

marcoambrosini avatar Oct 01 '22 13:10 marcoambrosini

Can we mark trailingButtonIcon as deprecated so we can remove it in a few major bump?

Did not mention deprecating anything?

Pytal avatar Oct 04 '22 04:10 Pytal

@Pytal We deliberately limited the functionality there to control the design a bit more. What trailing icon do you need there?

Would need the undo-variant icon from https://materialdesignicons.com, and had thought of adding another string undo to use this icon but thought that allowing any icon would prevent having to update the component each time a new icon is needed in the future

Pytal avatar Oct 04 '22 04:10 Pytal

Should we add the undo-variant icon case or allow any custom icon @marcoambrosini?

Pytal avatar Oct 12 '22 02:10 Pytal

Yes I think we should add only undo-variant and proceed slowly keep things under control. cc @jancborchardt @nimishavijay

marcoambrosini avatar Oct 18 '22 07:10 marcoambrosini

Review-ready

Pytal avatar Oct 18 '22 23:10 Pytal