nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

Drop sidebar position sticky

Open skjnldsv opened this issue 2 years ago • 2 comments

Now that the content is scrolling, the sticky is not needed anymore. Fixing the top/right values so it can apply on other locations if necessary. Especially the sidebar being full

Fixes this when resizing in firefox image

Explanations: Because there is a threesold where sticky positioning takes effect, scrolling makes a weird confusion in firefox where it doesn't understand whether to take the top: header-height or not

fix #3289

skjnldsv avatar Sep 29 '22 08:09 skjnldsv

Screenshots need updates?

nickvergessen avatar Sep 29 '22 09:09 nickvergessen

Screenshots need updates?

Done

skjnldsv avatar Oct 01 '22 11:10 skjnldsv

Woah, I thought that was merged long ago

skjnldsv avatar Oct 28 '22 05:10 skjnldsv

Should this be fixed in 25.0.2? Just wonder because I still experience the bug on c.nc.com

schiessle avatar Nov 30 '22 12:11 schiessle

If it's on talk, it's expected as we did not release yet.

nickvergessen avatar Dec 01 '22 11:12 nickvergessen

Yes, it was on Talk. So all core components are fixed with 25.0.2 and for each apps it will be fixed with the next app update, right?

schiessle avatar Dec 01 '22 15:12 schiessle

In theory yes, but we have another breaking side effect in 7.1 which currently blocks Talk from updating. It is being investigated atm but yeah hopefully in the next Talk version it's fixed

nickvergessen avatar Dec 01 '22 15:12 nickvergessen