nextcloud-vue
nextcloud-vue copied to clipboard
nextcloud-libraries
Better readability of long file and event names
Signed-off-by: Jérôme Herbinet [email protected]
Signed-off-by: Jérôme Herbinet [email protected]
Currently, in the right side panel, the labels end too easily with ellipsis dots. This is, from my personal and professional experience, too restrictive because we often cannot see the continuation of the file or event name (potentially also in any other similar case using this "vue"). It's a pain especially in Nextcloud Calendar but in Nextcloud Files too and probably in other apps.
I propose, with this change, to allow 3 lines to be displayed before the ellipsis.
Nextcloud Calendar test :
Nextcloud Files test :
Note : My only point of hesitation concerns the management of long (or even very long) unbreakable words with the "hyphens" CSS property, which sometimes causes a hyphen to appear just above the suspension points.
This property is only part of the CSS Overflow Module Level 3 specification which is not yet finalized. While the browser support seems to be surprisingly good, I am not sure, we should/want to use this property already.
@skjnldsv @marcoambrosini for opinions.
This PR would supersede #1788.
And what do you think of the question I was asking myself, concerning the hyphenation with the use of the CSS hyphen property. I said: My only point of hesitation concerns the management of long (or even very long) unbreakable words with the "hyphens" CSS property, which sometimes causes a hyphen to appear just above the suspension points.
cypress if failing :( It needs a snapshot update https://github.com/nextcloud/nextcloud-vue/blob/ad9e43cce49e7df19ec07b72781bf985302decec/package.json#L32
cypress if failing :( It needs a snapshot update
https://github.com/nextcloud/nextcloud-vue/blob/ad9e43cce49e7df19ec07b72781bf985302decec/package.json#L32
What should I do in this case ? 🤔
cypress if failing :( It needs a snapshot update
https://github.com/nextcloud/nextcloud-vue/blob/ad9e43cce49e7df19ec07b72781bf985302decec/package.json#L32
@skjnldsv can you tell me how to solve this problem (first time for me) ? Thx
@skjnldsv can you tell me how to solve this problem (first time for me) ? Thx
npm run cypress:update-snapshots
@skjnldsv can you tell me how to solve this problem (first time for me) ? Thx
npm run cypress:update-snapshots
If too complicated, I can replace this PR with a new one @skjnldsv, what do you think ?
You need to download the snapshots from the Github Cypress action. Updating the snapshots on your local machine likely won't work, as the snapshots generated will be different.