nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[BITV] Modal next/previous buttons contrast possibly too low

Open PVince81 opened this issue 3 years ago • 1 comments

Steps:

  1. Needs https://github.com/nextcloud/nextcloud-vue/pull/2953 (or click https://deploy-preview-2953--nextcloud-vue-components.netlify.app/#/Components/Modal)
  2. Open styleguide
  3. Scroll down and click on "Show modal with more properties"
  4. See the arrow buttons on the left and right of the modal
image

Now this is with a white background from the styleguide + darkened overlay color.

Whatever the solution is, I'm not sure if it can work with all backgrounds ?

The focus effect looks fine though when tabbing: image

PVince81 avatar Aug 05 '22 14:08 PVince81

@jancborchardt @nimishavijay

PVince81 avatar Aug 05 '22 14:08 PVince81

Since the background is always made dark with that overlay, the icons should be white – then it works contrast-wise as well. :)

jancborchardt avatar Aug 17 '22 11:08 jancborchardt

@jancborchardt I assume white only when not hovered

PVince81 avatar Aug 17 '22 15:08 PVince81

@Pytal can you adjust ? this will is the last item in https://github.com/nextcloud/nextcloud-vue/issues/2501 so we can then close that one too

PVince81 avatar Aug 17 '22 15:08 PVince81

Fixed in https://github.com/nextcloud/nextcloud-vue/pull/3080

Pytal avatar Aug 20 '22 01:08 Pytal