nextcloud-vue
nextcloud-vue copied to clipboard
[BITV] Modal next/previous buttons contrast possibly too low
Steps:
- Needs https://github.com/nextcloud/nextcloud-vue/pull/2953 (or click https://deploy-preview-2953--nextcloud-vue-components.netlify.app/#/Components/Modal)
- Open styleguide
- Scroll down and click on "Show modal with more properties"
- See the arrow buttons on the left and right of the modal
Now this is with a white background from the styleguide + darkened overlay color.
Whatever the solution is, I'm not sure if it can work with all backgrounds ?
The focus effect looks fine though when tabbing:

@jancborchardt @nimishavijay
Since the background is always made dark with that overlay, the icons should be white – then it works contrast-wise as well. :)
@jancborchardt I assume white only when not hovered
@Pytal can you adjust ? this will is the last item in https://github.com/nextcloud/nextcloud-vue/issues/2501 so we can then close that one too
Fixed in https://github.com/nextcloud/nextcloud-vue/pull/3080