nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[BITV/A11Y] Multiselect accessibility

Open PVince81 opened this issue 2 years ago • 2 comments

From workshop:

Found by Vincent in another ticket:

  • [x] multiselect should enable focus mode like other controls ? (still in browse mode when entering with tab)
  • [ ] multiselect entries are not read when moving with arrow keys in share dropdown (observed in right sidebar in files app)
  • [ ] multiselect should set the aria-describedby attribute to the input instead of leaving it on the main div?

More issues:

  • [ ] https://github.com/nextcloud/nextcloud-vue/issues/2951

PVince81 avatar Feb 17 '22 11:02 PVince81

any taker ? (even if just sub-items) @skjnldsv @Pytal @vinicius73 @raimund-schluessler

PVince81 avatar Aug 10 '22 20:08 PVince81

as discussed, it is likely that we'll need to find a new library

@CarlSchwan pointed out that vue-select might be suitable, however we will likely need to contribute accessibility fixes upstream

PVince81 avatar Aug 31 '22 10:08 PVince81

After searching around it seems the aforementioned https://github.com/sagalbot/vue-select is the best library for our purposes, the API seems pretty extensible and covers all if not most of our existing use cases as far as I can see

Pytal avatar Nov 02 '22 02:11 Pytal

note: will need backport to 25 (the matching nextcloud-vue version used there)

PVince81 avatar Nov 07 '22 17:11 PVince81

WIP https://github.com/nextcloud/nextcloud-vue/pull/3435

Pytal avatar Nov 08 '22 03:11 Pytal

there would be breaking changes if we impose this component to be a replacement of the old one

so, like for the date time picker, let's make it a new multiselect component and let it be opt-in and deprecate the old one which is not accessible

then we find the places in server and apps where we use it and then adjust to the new one

PVince81 avatar Nov 17 '22 16:11 PVince81

Tested and works with new component API @PVince81 https://github.com/nextcloud/nextcloud-vue/pull/3435#issuecomment-1325399075

Pytal avatar Nov 24 '22 02:11 Pytal

Transferred "After adding a person/group, focus should stay on the input field"

  • https://github.com/nextcloud/nextcloud-vue/issues/3570

Pytal avatar Dec 14 '22 00:12 Pytal

Transferred "User status dialog "Clear status after" menu entries need border for focus feedback"

  • https://github.com/nextcloud/server/issues/35763

Pytal avatar Dec 14 '22 00:12 Pytal