nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[BITV] Modal dialog accessibility

Open PVince81 opened this issue 3 years ago • 3 comments

Needs to be a proper modal, see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role

  • [x] The div needs to have role="dialog": https://github.com/nextcloud/nextcloud-vue/issues/1590 https://github.com/nextcloud/nextcloud-vue/pull/2696
  • [x] nextcloud/nextcloud-vue#2810
  • [x] Keep focus within the dialog, prevent tabbing through elements in background: https://github.com/nextcloud/nextcloud-vue/issues/1591
  • [x] nextcloud/nextcloud-vue#2811
  • [x] Prev/next arrows are not focusable at all, and should be buttons https://github.com/nextcloud/nextcloud-vue/pull/2695
  • [x] nextcloud/nextcloud-vue#2815
  • [x] nextcloud/nextcloud-vue#2816
  • ~~nextcloud/viewer#1311~~
  • ~~nextcloud/viewer#1312~~
  • [x] nextcloud/nextcloud-vue#2814
  • [x] https://github.com/nextcloud/nextcloud-vue/issues/2954
  • [ ] https://github.com/nextcloud/nextcloud-vue/issues/3088

PVince81 avatar Feb 17 '22 10:02 PVince81

https://github.com/nextcloud/nextcloud-vue/pull/2654

vanpertsch avatar Apr 25 '22 07:04 vanpertsch

I've transferred the "image viewer" tickets to the viewer repo

originally that checkbox list was a dump of my findings where I was looking at various modals and their contents

PVince81 avatar Aug 05 '22 12:08 PVince81

remaining task, was a result of an accessibility review and an answer to the question whether we should automatically focus inside a dialog that was just opened: https://github.com/nextcloud/nextcloud-vue/issues/3088

PVince81 avatar Aug 26 '22 06:08 PVince81

all closed

JuliaKirschenheuter avatar Nov 21 '22 09:11 JuliaKirschenheuter