refactor: Scope package into modules
What do you think of this idea?
- Implements: https://github.com/nextcloud-libraries/nextcloud-files/issues/1015
This splits the package into two modules:
- The default one (
@nextcloud/files) which provides general utils to work with files or the files app - DAV utils (
@nextcloud/files/dav) which provides WebDAV related utils
For legacy reasons to not make this a breaking release the DAV utils are exported with their prefixed names in the default module, but this will be then removed with the next major version.
Bundle Report
Changes will increase total bundle size by 247.08kB (101.54%) :arrow_up::warning:, exceeding the configured threshold of 5%.
| Bundle name | Size | Change |
|---|---|---|
| @nextcloud/files-cjs | 124.38kB | 124.38kB (100%) :arrow_up::warning: |
| @nextcloud/files-cjs-esm | 122.7kB | 122.7kB (100%) :arrow_up::warning: |
I would still prefer do a breaking release and push this for nc 31 and above? :)
I would still prefer do a breaking release and push this for nc 31 and above? :)
Sure I just wanted to make it non breaking so we might can keep compatible library versions longer for NC releases. But if you prefer to do this directly breaking, then I can adjust the PR :)
But if you prefer to do this directly breaking, then I can adjust the PR :)
I personally don't mind both. I'll leave it up to you, if keeping it backward compatible is more maintenance pain, then let's just make a new major. If you think it's not too much work, let's make it a minor then :rocket:
Codecov Report
Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
Project coverage is 91.77%. Comparing base (
7a25265) to head (781517b). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/dav/dav.ts | 85.71% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1025 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 23 23
Lines 632 632
Branches 166 166
=======================================
Hits 580 580
Misses 45 45
Partials 7 7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.