next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

Use consistent error type between doc, logger and error class

Open sato11 opened this issue 2 years ago โ€ข 3 comments

โ˜•๏ธ Reasoning

Following up this comment: https://github.com/nextauthjs/next-auth/pull/5027#issuecomment-1197053995.

I've abstained from further renaming it like CALLBACK_ERROR, since my original intention is only to make them consistent. I'm feeling happy enough with OAUTH_CALLBACK_ERROR, partly because I am not really sure over the intention of renaming. So I'd like to leave that to you.

About the doc, two changes have been made: merging CALLBACK_OAUTH_ERROR and oauth_callback_error, and relocating openid-client stuff to SIGNIN_OAUTH_ERROR section. Background of the latter change is reasoned in #5045.

Commits are separately made, but if you want me to squash them let me know.

๐Ÿงข Checklist

  • [x] Documentation
  • [x] Tests
  • [ ] Ready to be merged

๐ŸŽซ Affected issues

Closes: #5045

๐Ÿ“Œ Resources

sato11 avatar Jul 29 '22 11:07 sato11

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated
next-auth โœ… Ready (Inspect) Visit Preview Aug 21, 2022 at 8:00AM (UTC)

vercel[bot] avatar Jul 29 '22 11:07 vercel[bot]

@ThangHuuVu Thanks for the feedback. How does it look to you now?

sato11 avatar Aug 02 '22 05:08 sato11

@ndom91 @lluia I was wondering if changing the error code requires a bump in semver ๐Ÿค” WDYT?

ThangHuuVu avatar Aug 02 '22 16:08 ThangHuuVu