next-auth
next-auth copied to clipboard
refactor(core): use standard `Request` and `Response`
Continues #4704, should be merged before #4299
- [x] parse body
- [x] handle cookies
- [ ] verify (detect host), normalize (full URL), fallback (localhost) URL
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
next-auth | ⬜️ Ignored (Inspect) | Dec 3, 2022 at 1:35PM (UTC) |
Looks like Jest vs. Node.js has a different Response
:face_exhaling: need to work it out for tests to pass.
🎉 Experimental release published 📦️ on npm!
pnpm add [email protected]
yarn add [email protected]
npm i [email protected]
Changes make sense to me!
Hi! This indeed was a nice improvement. But unfortunately this change caused a breaking change for libs depending on NextAuthHandler
, like @sidebase/nuxt-auth and next-auth/apps/playground-nuxt, but it was released as patch version. I think a warning should be added to release notes in case other libs face the same issue.
@JoaoPedroAS51 well TBF they didn't tell anyone to use their INTERNALS YET. They only have the default React and Next usage available in the public.
So if your library is using NextAuthHandler
, which is not documented somewhere, yet, it's most likely not their fault.
@walmartwarlord Yeah, I understand your point. And if this is the case, I understand why this was a patch version. We weren't aware it was internal since the example for nuxt app integration used it and there was no @internal
flag in the function to indicate. We just followed the approach from there.
I just commented here to warn in case this wasn't an intentional breaking change.