feat(cookies): make pkce and state maxAge configurable on the cookies…

[jason-brady-mythical]

… (#4660)

☕️ Reasoning

Currently the maxAge and the expires on the cookie options are being set to a hard coded 15 minutes. These changes allow the consumer to configure the maxAge for the pkce and state cookies options. If the cookie options are not set they are defaulted to the 15 minutes.

🧢 Checklist

• [x] Documentation
• [ ] Tests
• [x] Ready to be merged

🎫 Affected issues

Fixes: 4660

📌 Resources

• Contributing guidelines
• Code of conduct
• Contributing to Open Source

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
next-auth	✅ Ready (Inspect)	Visit Preview	Nov 30, 2022 at 3:38PM (UTC)

[jason-brady-mythical]

@balazsorban44 Any chance of getting this PR looked at some time soon? Thanks.

[ThangHuuVu]

Thanks for the clean PR! Would you be interested in adding some tests to createPKCE and createState as well? We're trying to increase test coverage in this project, so it would be really nice if you could add them to the PR too 💚

[jason-brady-mythical]

Yes I will add some tests.

[jason-brady-mythical]

@ThangHuuVu updated this pr with tests around createPKCE and createState.

[jason-brady-mythical]

@ThangHuuVu @balazsorban44 Anything else needed to try and get this merged?

[twhitson]

This is a blocker for me as well. Do we know how long until this will be merged and released?

[ndom91]

Thanks for the tests as well :clap:

[jason-brady-mythical]

@ndom91 @ThangHuuVu I am not able to merge as this needs a maintainer to approve running workflows. Is there something else I need to do?

[ThangHuuVu]

@jason-brady-mythical I approved the workflow, could you update the branch one more time?

[jason-brady-mythical]

@ThangHuuVu Updated, not sure what else is needed.

[C3mkal]

#5664