next-auth
next-auth copied to clipboard
Add a ChiselStrike database adapter
โ๏ธ Reasoning
Add a DB adapter for ChiselStrike.
๐งข Checklist
- [x] Documentation
- [x] Tests
- [x] Ready to be merged
๐ซ Affected issues
N/A
๐ Resources
- Contributing guidelines
- Code of conduct
- Contributing to Open Source
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| next-auth | โฌ๏ธ Ignored (Inspect) | Jun 23, 2022 at 7:47PM (UTC) |
Adapters are not classes, could you rewrite to be a pure function instead?
Done.
Polyfilling sounds unnecessary as well, as Next.js already does this.
I presume you mean cross-fetch? I replaced it with node-fetch.
Rebased on top of latest main. @balazsorban44 PTAL.
@balazsorban44 Ping, I have just released a version of ChiselStrike with NextAuth integration (https://github.com/chiselstrike/chiselstrike/releases/tag/v0.10.0) but this pull request looks to have gone state. Please let us know what we need to do to get this upstreamed, and we'll be happy to do the work.
@dekimir is attempting to deploy a commit to the NextAuth Team on Vercel.
A member of the Team first needs to authorize it.
fetchis globally available in Next.js, no polyfilling is necessary.
OK, but how do I get jest to recognize that? No matter what I try in jest.config.js, I get ReferenceError: fetch is not defined when I run pnpm test.
OK, we managed to drop the polyfill (except in testing). @balazsorban44 that's all the feedback adressed.
(Also, please ignore the vercel bot; that's a temporary mistake I fixed.)
I think there was an accidentally made change here, when you probably tried fixing some merge conflicts. This PR should only have added a new adapter but made a bunch of changes. Could you make sure this is not the case? ๐
I think there was an accidentally made change here, when you probably tried fixing some merge conflicts. This PR should only have added a new adapter but made a bunch of changes. Could you make sure this is not the case? pray
I thought I fixed that? I don't see any changes here outside packages/adapter-chiselstrike...
Hmm, maybe it was the GitHub UI acting up, looks good now. I'll have a look thanks!
Make sure to start putting in names of persons . the identity of the person you are helping to best provide credentials . Open network means trust in character to best suit the personal fixings of the identities property !
Best , Justin แง
On Fri, May 27, 2022 at 12:12 PM Dejan Mircevski @.***> wrote:
Rebased on top of latest main. @balazsorban44 https://github.com/balazsorban44 PTAL.
โ Reply to this email directly, view it on GitHub https://github.com/nextauthjs/next-auth/pull/4573#issuecomment-1139759693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYXI3ITPI556EKT4VOURETLVMDX7DANCNFSM5WDMMYFA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
hi @dekimir, I see that this PR hasn't been touched recently, do you think you can pick up the pieces and get this in soon? ๐ข About formatting, you can take a look at https://github.com/nextauthjs/next-auth/pull/6745 as a reference for:
- JSDoc for documentation
- ESM output (check the package.json file) Let me know if you have any questions!
hi @dekimir, I see that this PR hasn't been touched recently, do you think you can pick up the pieces and get this in soon?
Sorry, I'm unable to work on this any further. Perhaps @penberg might be talked into taking it over...
To keep things tidy, we are closing this issue for now. If you think your issue is still relevant, leave a comment and we might reopen it. Thanks!