next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

Add a ChiselStrike database adapter

Open dekimir opened this issue 3 years ago โ€ข 11 comments

โ˜•๏ธ Reasoning

Add a DB adapter for ChiselStrike.

๐Ÿงข Checklist

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged

๐ŸŽซ Affected issues

N/A

๐Ÿ“Œ Resources

dekimir avatar May 17 '22 02:05 dekimir

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Ignored Deployment
Name Status Preview Updated
next-auth โฌœ๏ธ Ignored (Inspect) Jun 23, 2022 at 7:47PM (UTC)

vercel[bot] avatar May 17 '22 02:05 vercel[bot]

Adapters are not classes, could you rewrite to be a pure function instead?

Done.

Polyfilling sounds unnecessary as well, as Next.js already does this.

I presume you mean cross-fetch? I replaced it with node-fetch.

dekimir avatar May 20 '22 03:05 dekimir

Rebased on top of latest main. @balazsorban44 PTAL.

dekimir avatar May 27 '22 16:05 dekimir

@balazsorban44 Ping, I have just released a version of ChiselStrike with NextAuth integration (https://github.com/chiselstrike/chiselstrike/releases/tag/v0.10.0) but this pull request looks to have gone state. Please let us know what we need to do to get this upstreamed, and we'll be happy to do the work.

penberg avatar Jun 11 '22 05:06 penberg

@dekimir is attempting to deploy a commit to the NextAuth Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 24 '22 15:06 vercel[bot]

fetch is globally available in Next.js, no polyfilling is necessary.

OK, but how do I get jest to recognize that? No matter what I try in jest.config.js, I get ReferenceError: fetch is not defined when I run pnpm test.

dekimir avatar Jun 24 '22 15:06 dekimir

OK, we managed to drop the polyfill (except in testing). @balazsorban44 that's all the feedback adressed.

(Also, please ignore the vercel bot; that's a temporary mistake I fixed.)

dekimir avatar Jun 24 '22 21:06 dekimir

I think there was an accidentally made change here, when you probably tried fixing some merge conflicts. This PR should only have added a new adapter but made a bunch of changes. Could you make sure this is not the case? ๐Ÿ™

balazsorban44 avatar Jun 24 '22 21:06 balazsorban44

I think there was an accidentally made change here, when you probably tried fixing some merge conflicts. This PR should only have added a new adapter but made a bunch of changes. Could you make sure this is not the case? pray

I thought I fixed that? I don't see any changes here outside packages/adapter-chiselstrike...

dekimir avatar Jun 24 '22 21:06 dekimir

Hmm, maybe it was the GitHub UI acting up, looks good now. I'll have a look thanks!

balazsorban44 avatar Jun 26 '22 12:06 balazsorban44

Make sure to start putting in names of persons . the identity of the person you are helping to best provide credentials . Open network means trust in character to best suit the personal fixings of the identities property !

Best , Justin แง

On Fri, May 27, 2022 at 12:12 PM Dejan Mircevski @.***> wrote:

Rebased on top of latest main. @balazsorban44 https://github.com/balazsorban44 PTAL.

โ€” Reply to this email directly, view it on GitHub https://github.com/nextauthjs/next-auth/pull/4573#issuecomment-1139759693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYXI3ITPI556EKT4VOURETLVMDX7DANCNFSM5WDMMYFA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LOGOLFGODORD avatar Jul 05 '22 09:07 LOGOLFGODORD

hi @dekimir, I see that this PR hasn't been touched recently, do you think you can pick up the pieces and get this in soon? ๐Ÿšข About formatting, you can take a look at https://github.com/nextauthjs/next-auth/pull/6745 as a reference for:

  • JSDoc for documentation
  • ESM output (check the package.json file) Let me know if you have any questions!

ThangHuuVu avatar Jul 10 '23 16:07 ThangHuuVu

hi @dekimir, I see that this PR hasn't been touched recently, do you think you can pick up the pieces and get this in soon?

Sorry, I'm unable to work on this any further. Perhaps @penberg might be talked into taking it over...

dekimir avatar Jul 10 '23 16:07 dekimir

To keep things tidy, we are closing this issue for now. If you think your issue is still relevant, leave a comment and we might reopen it. Thanks!

stale[bot] avatar Sep 16 '23 19:09 stale[bot]