next-auth
next-auth copied to clipboard
Allow Specifying full oidc-client Issuer Metadata without Discovery
Reasoning ๐ก
Allow setting the full oidc-client Issuer metadata without using Issuer discovery by making issuer
string|IssuerMetadata
. I would argue that issuer
is completely useless without setting jwks_uri, and the type should probably be migrated to IssuerMetadata|undefined
fully at some point, potentially making it mutually exclusive with wellKnown
.
This could be considered a breaking change due to removing the jwks_endpoint property from the Typescript types. However, this property was fully ignored so far.
Checklist ๐งข
- [ ] Documentation
- [ ] Tests
- [x] Ready to be merged
Affected issues ๐
Fixes #3567
It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!
Well, has this been fixed otherwise?
It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!
Thanks for the PR! I look this up and see that in the past there was an attempt with a similar goal #3583, but I like your PR better.
Previously jwks_uri
is passed in when constructing the Issuer
, but we removed it in favor of wellKnown
. @balazsorban44 what do you think about bringing it back for this use case?
Would be great if this can be merged. ๐
Some OIDC providers implement the Core specification, does not implement the Discovery spec, and only supports id_token
response type.
The only missing piece getting NextAuth to work with this provider is to support setting jwks_uri
property.
Is there a workaround to specify jwks_uri without this change @ThangHuuVu ?
Be great if this could get looked at again. If we don't use wellKnown we need to be able to set jwks_uri
@flchaux no workaround from userland since the issuer object is created in the core - you could use patch-package
to patch the fix while waiting for the merge & next release
@shartte sorry for the delayed response, let's get it in. Could you resolve the conflict one more time? ๐
@ThangHuuVu Sorry, but I no longer use this project.
Is there any updates on this?
Let's close this PR now. If anyone is interested, feel free to open a new PR to our v4 branch - that's where we're accepting new PRs for the next-auth
package.