next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

feat: improve sveltekit example app with protected and admin routes

Open vishnuchandrappan opened this issue 1 year ago • 4 comments

☕️ Reasoning

Not a bug. More of an improvement to the sveltekit example with proper reference to authentication and authorisation.

🧢 Checklist

  • [x] Documentation (sort of)
  • [ ] Tests (not applicable)
  • [x] Ready to be merged

🎫 Affected issues

📌 Resources

⚠️ Notes

  • I have seen that the live example https://sveltekit-auth-example.vercel.app/ and the code I just edited are not similar.

vishnuchandrappan avatar Nov 23 '24 13:11 vishnuchandrappan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 11:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:58am

vercel[bot] avatar Nov 23 '24 13:11 vercel[bot]

@vishnuchandrappan is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 23 '24 13:11 vercel[bot]

@vishnuchandrappan thanks for this update!

As you noticed, the deployed example is not the code yuo've edited. For context, we usually have 2 apps for each client/framework in this monorepo.

  1. The ones under apps/dev/*, like the one you edited, are designed to be used for local development only. They're the ones that should be started with the root npm script dev:sveltekit (for example).
  2. The other app you linked, is located under apps/examples/* and these are designed only to be synced to their respective demo repos and then deployed via Vercel as legit demos for folks to play around with. i.e. the apps/examples/sveltekit app is synced to nextauthjs/sveltekit-auth-example (see this file for sync details)

As a sidenote, there's another PR in flight updating the sveltekit demo app (apps/examples/sveltekit/*) here: #12287

ndom91 avatar Nov 27 '24 13:11 ndom91

It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!

stale[bot] avatar Jan 31 '25 22:01 stale[bot]