next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

feat(adapters): add remult adapter

Open jycouet opened this issue 1 year ago โ€ข 14 comments

โ˜•๏ธ Reasoning

Adding a new adapter @auth/remult-adapter

๐Ÿงข Checklist

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged
    • [x] @noam-honig I would like you to check it before adding "ready"

๐ŸŽซ Affected issues

๐Ÿ“Œ Resources

jycouet avatar Sep 03 '24 20:09 jycouet

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
auth-docs โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Oct 18, 2024 5:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs โฌœ๏ธ Ignored (Inspect) Visit Preview Oct 18, 2024 5:22pm

vercel[bot] avatar Sep 03 '24 20:09 vercel[bot]

@jycouet is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 03 '24 20:09 vercel[bot]

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

github-actions[bot] avatar Sep 03 '24 20:09 github-actions[bot]

hi @ubbe-xyz @ndom91 @ThangHuuVu @balazsorban44 Please let me know if you need anything else to proceed.

jycouet avatar Sep 12 '24 07:09 jycouet

As the creator of remult - this looks great, can't wait for this to get merged

noam-honig avatar Sep 12 '24 07:09 noam-honig

As the creator of remult - this looks great, can't wait for this to get merged

+1

yoni-rapoport avatar Oct 07 '24 09:10 yoni-rapoport

Codecov Report

Attention: Patch coverage is 96.89579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 40.13%. Comparing base (e91073f) to head (749cf8f). Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
packages/adapter-remult/src/index.ts 95.30% 14 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11762      +/-   ##
==========================================
+ Coverage   39.05%   40.13%   +1.07%     
==========================================
  Files         191      193       +2     
  Lines       29994    30303     +309     
  Branches     1294     1355      +61     
==========================================
+ Hits        11715    12162     +447     
+ Misses      18279    18141     -138     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 01:10 codecov[bot]

I updated the PR to used an existing container & pulled main to resolve conflics. Could you run tests again please? Thx

jycouet avatar Oct 08 '24 08:10 jycouet

@balazsorban44 could you advice why we get:

Error response from daemon: No such container: next-auth-postgres-test

I'm using this in prod on my side. It would be good to finish the effort to merge it here as well ๐Ÿ‘

Let me know,

jycouet avatar Oct 18 '24 14:10 jycouet

Tadaaa ๐Ÿฅณ All green, I guess that @balazsorban44 you would need to allow Vercel to be 100%

Then ready to merge? :)

jycouet avatar Oct 18 '24 17:10 jycouet

@balazsorban44 we had a few users requesting it. Could you have a look and validate this adapter ? :) Thank you

jycouet avatar Nov 10 '24 17:11 jycouet

@balazsorban44 we need this please. We will appreciate your looking into and authorising the merge. Thanks

shiftlabs1 avatar Nov 10 '24 17:11 shiftlabs1

@balazsorban44 should I resolve conflicts ?

jycouet avatar Jan 14 '25 21:01 jycouet

Authjs team, any updates on this? Anything we can do to help?

ermincelikovic avatar Feb 06 '25 07:02 ermincelikovic