next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

chore(docs): add solidstart example app

Open halvaradop opened this issue 1 year ago • 11 comments

☕️ Reasoning

This pull request introduces an object containing information about SolidStart to be displayed on the root page of the documentation. It expands the documentation of the examples supported by Auth.js.

Screenshots: image image

🧢 Checklist

  • [x] Documentation
  • [ ] Tests
  • [x] Ready to be merged

🎫 Affected issues

📌 Resources

halvaradop avatar Aug 29 '24 15:08 halvaradop

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 10:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:10pm

vercel[bot] avatar Aug 29 '24 15:08 vercel[bot]

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 29 '24 15:08 vercel[bot]

I like the initiative! However that example app doesn't exist yet, right.

ndom91 avatar Aug 29 '24 15:08 ndom91

I'm not sure if the example app doesn't exist, but I saw that the repository contains this link. However, if you're referring to the link being broken, you're right. This link behaves the same as the Qwik example app link, so please check them.

halvaradop avatar Aug 29 '24 16:08 halvaradop

Okay so the Qwik one is fixed. The Solid-Start one is mostly fixed, but the example app won't be able to be deployed successfully until there's a new publish of the @auth/solid-start package due to some critical updates I just merged htere as well. Shouldn't take too long :crossed_fingers:

ndom91 avatar Sep 02 '24 19:09 ndom91

Thank you for considering my suggestions! I’ll be looking forward to the new auth/solid-start publication.

halvaradop avatar Sep 04 '24 00:09 halvaradop

~This is not shown for a reason. We are not yet confident in our current implementation. The link you added even 404's. https://solid-start-auth-example.vercel.app/~

Sorry, missed the discussion with @ndom91

Let's await merging it until the example is up and running.

balazsorban44 avatar Sep 04 '24 09:09 balazsorban44

Why did you close? Still working on this haha

ndom91 avatar Sep 19 '24 08:09 ndom91

Nooo 😔, I think I accidentally deleted the branch haha. I’ve reopened the PR. Thank you for letting me know

halvaradop avatar Sep 19 '24 14:09 halvaradop

The current state of this is as follows:

  • We need the solid-start-example-app Vercel project to deploy successfully so we can merge this because it points at that demo project.
  • We recently released a new version of the @auth/solid-start client which does build correctly
  • Howeverrr, the demo project is still having issues deploying on Vercel.

image

In the project's Vercel settings the node version is set to 20 and I updated the engines key in the package.json as well from "node": ">=16" to "node": "^18.17.0 || ^20.3.0 || >=21.0.0", but it still throws this error. Do you have any idea why else this might be throwing this error at build?

ndom91 avatar Sep 22 '24 09:09 ndom91

I'm not sure, but I plan to deploy the demo. I’ll use the repo as a template for the deployment. If I have good results, I’ll get back to you with an update.

halvaradop avatar Sep 24 '24 03:09 halvaradop