next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

chore: clean up custom error section and add repository links

Open halvaradop opened this issue 1 year ago • 2 comments

ā˜•ļø Reasoning

This pull request cleans up the custom error section in guides/pages by removing the example code for the frameworks (currently located below this content). It also adds links to the repositories supported by Auth.js, including: Next.js, SvelteKit, Express, Solid, and Qwik.

🧢 Checklist

  • [x] Documentation
  • [ ] Tests
  • [x] Ready to be merged

šŸŽ« Affected issues

šŸ“Œ Resources

halvaradop avatar Aug 26 '24 01:08 halvaradop

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
auth-docs āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Aug 27, 2024 1:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ā¬œļø Ignored (Inspect) Visit Preview Aug 27, 2024 1:22pm

vercel[bot] avatar Aug 26 '24 01:08 vercel[bot]

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 26 '24 01:08 vercel[bot]

The existing examples don't contain an error page example at all. I think the existing "Custom Error Page' example is good as-is :pray:

ndom91 avatar Aug 28 '24 19:08 ndom91

I’m not sure how useful that solution is because, as I understand it, this section is meant for creating a custom error page, and it does not contain the relevant content. However, at the bottom of the section, there is information on how to do this using Next.js, with code that includes the same component name and directory. For this reason, I have removed that code.

On the other hand, I think it would be beneficial to add links to other frameworks supported by Auth.js to help users build a custom error page using framework-specific templates.

halvaradop avatar Aug 29 '24 00:08 halvaradop