next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

fix: add provider/adpaters logos in dark mode

Open dhairyathedev opened this issue 1 year ago • 4 comments

☕️ Reasoning

The icons were breaking in dark mode because their dark colors didn’t provide enough contrast.

🧢 Checklist

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged

📌 Resources

dhairyathedev avatar Jun 22 '24 09:06 dhairyathedev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 10:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2024 10:03am

vercel[bot] avatar Jun 22 '24 09:06 vercel[bot]

@dhairyathedev is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 22 '24 09:06 vercel[bot]

Can you provide a screenshot? Where do you mean it was breaking exactly?

Were trying to avoid maintaining two copies of each logo

ndom91 avatar Jun 24 '24 03:06 ndom91

One example is https://authjs.dev/getting-started/authentication/oauth where the GitHub and Okta logo is not visible in dark mode. There are lots of logos in providers list where the image is not visible in dark mode.

image

Were trying to avoid maintaining two copies of each logo

Actually I tried changing the fill color using tailwind css, but it is not possible to change the fill color of path in svg when rendered using img tag. The solution to this issue, is to use SVG directly in the code or creating seperate variant for dark mode.

If you know a better way then please let me know.

dhairyathedev avatar Jun 24 '24 07:06 dhairyathedev

as said, we are trying to avoid more icons.

Let's revisit this in a new PR.

balazsorban44 avatar Sep 15 '24 19:09 balazsorban44