nextauthjs
chore(providers): rename 42School to FortyTwo
☕️ Reasoning
42School Provider works but documentation was reflecting a different providerName. In fact, the providerName had spaces and starts with numbers. I have replaced all instances of the providerName so that documentation and the getting started guides reflect the correct providerName.
Changed from 42School or 42 School in the documentation to FortyTwo in this PR.
🧢 Checklist
- [x] Documentation
- [ ] Tests
- [ ] Ready to be merged
🎫 Affected issues
📌 Resources
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| auth-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 10:22am |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| next-auth-docs | ⬜️ Ignored (Inspect) | Visit Preview | Jul 2, 2024 10:22am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ikersojo is attempting to deploy a commit to the authjs Team on Vercel.
A member of the Team first needs to authorize it.
@k-taro56 thanks for that big PR! I left a littel note there.
After we cleanup the 42School imports, etc. there though, we can continue in this PR with any required docs changes to make everything match again (i.e. in docs/pages/getting-started/providers/42-school.mdx potentially). Cool with everyone?
@ikersojo I'll ping you here once that other PR is merged and then we'd appreciate it if you could modify this to make the docs match any code changes :pray:
Sure, happy to help!
We've merged that PR, would love if you could clean this up and we can ship the rest of your 42school fixes 👍
It was suggested by @ndom91 to align everything to 'FortyTwo'. Since it was already a breaking change, I am proposing to go for 'FortyTwoSchool', as a mix between both naming schemes.
We can revert the changes to the naming scheme. As said before, this PR was a documentation fix, but as a 42 student, I am happy to help. Please let me know how to proceed.
My main concern is with the import path change: 42-school -> fortyTwoSchool ❌. This seems unnecessary, breaking, and not aligned with the case convention.
42School -> FortyTwoSchool seems also wrong, searching for 42 in our docs would not work anymore.
I'll close this for now as I think this would be confusing to current users, breaking for a name change.
