next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

feat(providers): add SimpleLogin oidc

Open alexaka1 opened this issue 1 year ago โ€ข 3 comments

โ˜•๏ธ Reasoning

Adds Sign in with SimpleLogin support.

SimpleLogin is built for privacy-conscious site owners and protects your users identity. Open-source, Developer-first, SimpleLogin can be integrated in minutes.

๐Ÿงข Checklist

  • [X] Documentation
  • [X] Tests
  • [X] Ready to be merged

๐ŸŽซ Affected issues

๐Ÿ“Œ Resources

alexaka1 avatar Apr 06 '24 11:04 alexaka1

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
auth-docs โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 1, 2024 10:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs โฌœ๏ธ Ignored (Inspect) Visit Preview Jun 1, 2024 10:55am

vercel[bot] avatar Apr 06 '24 11:04 vercel[bot]

@alexaka1 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 06 '24 11:04 vercel[bot]

I am not sure what tests are necessary. I have tested the code with my own website, and users are able to log in with SimpleLogin. I would love some input from a maintainer about tests.

alexaka1 avatar Apr 06 '24 11:04 alexaka1

This looks pretty good already! Can you add a docs page at /docs/pages/getting-started/providers/simplelogin.mdx?

Thanks ๐Ÿ™

ndom91 avatar May 12 '24 20:05 ndom91

I have included an mdx.

alexaka1 avatar May 18 '24 10:05 alexaka1

Two minor nit picks,

  1. Is the brand color really #fff? Maybe lets go with their pink-ish color from the logo
  2. There seems to be a prettier issue in your mdx file (docs/pages/getting-started/providers/simplelogin.mdx)

ndom91 avatar May 19 '24 16:05 ndom91

Tbh, I couldn't figure out what the brand color does. But will get them fixed.

alexaka1 avatar May 19 '24 16:05 alexaka1

Codecov Report

Attention: Patch coverage is 0% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 40.75%. Comparing base (f1bf7ae) to head (bed93e1).

:exclamation: Current head bed93e1 differs from pull request most recent head b39ad83

Please upload reports for the commit b39ad83 to get more accurate results.

Files Patch % Lines
packages/core/src/providers/simplelogin.ts 0.00% 107 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10491      +/-   ##
==========================================
- Coverage   40.91%   40.75%   -0.16%     
==========================================
  Files         176      177       +1     
  Lines       27924    28031     +107     
  Branches     1243     1244       +1     
==========================================
  Hits        11424    11424              
- Misses      16500    16607     +107     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 19 '24 17:05 codecov[bot]