next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

Update github.ts

Open tautastic opened this issue 1 year ago • 2 comments

☕️ Reasoning

This PR addresses an inconsistency in the GitHub provider within NextAuth.js. Currently, the GitHub provider fails to expose the email_verified status provided by GitHub, even though this information is readily available in the API response. This change will add the email_verified field to the GitHubProfile interface and expose it in the provider's user information.

🧢 Checklist

[ ] Documentation (No significant documentation changes were required) [ ] Tests (Existing tests should cover the changed behavior, potential for adding more if needed) [x] Ready to be merged

🎫 Affected issues

https://github.com/nextauthjs/next-auth/issues/10013

tautastic avatar Feb 13 '24 12:02 tautastic

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Feb 13, 2024 0:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 0:54am

vercel[bot] avatar Feb 13 '24 12:02 vercel[bot]

@tautastic is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 13 '24 12:02 vercel[bot]

I'm going to close this PR and issue. This is not something that belongs in the GitHub provider by default imo. Obviously feel free to do as you wish in your application.

Sidenote, the emailVerified field is of type Date to indicate when an Email was verified with one of the Email / Magic Link providers. See: https://authjs.dev/reference/core/adapters#emailverified

ndom91 avatar May 19 '24 12:05 ndom91