next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

fix: sveltekit-example-app to use new API

Open ndom91 opened this issue 1 year ago โ€ข 2 comments

โ˜•๏ธ Reasoning

  • Bring SvelteKit example app up to speed with latest API
  • No other style / design updates really
  • There is 1 other change I've made here - swapped the SvelteKit component's button/slot order to be slot/button.
    • Been having trouble with the order of the slots in these new SvelteKit SignIn/SignOut components in every app I've tried to use them in so far.. Swapping them puts the onus on the user to pass at least a <button type"submit" /> if they want to make it work, but if its doucmented and in all the examples I think thats ifne. Otherwise the user is forced to do all sorts of weird CSS workarounds to style the button above the slot which just gets in the way.

๐Ÿงข Checklist

  • [ ] Documentation
  • [ ] Tests
  • [x] Ready to be merged

๐ŸŽซ Affected issues

๐Ÿ“Œ Resources

ndom91 avatar Feb 12 '24 17:02 ndom91

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
auth-docs โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 29, 2024 2:29pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs โฌœ๏ธ Ignored (Inspect) Visit Preview Feb 29, 2024 2:29pm
nextra-docs โฌœ๏ธ Ignored (Inspect) Visit Preview Feb 29, 2024 2:29pm

vercel[bot] avatar Feb 12 '24 17:02 vercel[bot]

No dependency changes detected. Learn more about Socket for GitHub โ†—๏ธŽ

๐Ÿ‘ No dependency changes detected in pull request

socket-security[bot] avatar Feb 29 '24 13:02 socket-security[bot]