spotlight icon indicating copy to clipboard operation
spotlight copied to clipboard

Update README.md

Open eensander opened this issue 2 years ago • 2 comments

This commit proposes two modifications to the README.md:

  1. The unpkg.com link on line 235 seems to be invalid. Looking at your npm profile, it looks like the correct package is spotlight.js, which is what I changed it to.
  2. On line 270, an example of non-anchor elements if given. However, the HTML-tags do not correspond. Based on the earlier examples, I assume the div tag should be a a tag.

eensander avatar Feb 09 '22 13:02 eensander

Thank you for fixing this, @eensander. I also saw this and am happy, you already made an PR.

Exept, the second is incorrect. As non-anchor element in my understanding it must be:

<div class="spotlight" data-src="img1.jpg">
    <!-- image or any other elements -->
</div>

Have a nice day :-)

madiko avatar Jun 02 '22 08:06 madiko

@madiko

Thank you for your reply. I think I indeed misinterpreted the term 'non-anchor' element: your suggestions seems more sensical. I have updated those lines to reflect your suggestion.

If I'm correct, the PR should now be good to merge.

eensander avatar Jun 13 '22 14:06 eensander