vulnerablecode icon indicating copy to clipboard operation
vulnerablecode copied to clipboard

Implement Descending Sorting for Packages and Vulnerabilities in API and UI

Open NucleonGodX opened this issue 11 months ago • 5 comments

#1754 image image

Used aliases to sort vulnerabilities in descending order and implemented version-based sorting for packages in both the API and UI.

NucleonGodX avatar Jan 23 '25 19:01 NucleonGodX

Thanks! do you mind to add some tests?

In particular we need to make sure that this does not impact performance badly so the perf there at scale need to be in a test.

pombredanne avatar Jan 24 '25 13:01 pombredanne

Thanks! do you mind to add some tests?

In particular we need to make sure that this does not impact performance badly so the perf there at scale need to be in a test.

Hey @pombredanne, How can we perform those tests?

NucleonGodX avatar Feb 02 '25 17:02 NucleonGodX

Hey @NucleonGodX , I think @pombredanne wants you to add "Unit Test" for your changes. To make those unit tests you need to make a new test file at vulnerabilities/tests for your specific test for example as said above "to make sure that this does not impact performance badly".

Dedsec0098 avatar Feb 09 '25 19:02 Dedsec0098

@NucleonGodX a gentle reminder, is this PR active ?

TG1999 avatar Apr 18 '25 14:04 TG1999

Hi @TG1999, actually when I opened this PR, I discussed this with @keshav-space in the weekly meet regarding the performance test cases, and he informed me that they aren't necessarily required, so I didn't add anything else in this PR.

NucleonGodX avatar Apr 20 '25 06:04 NucleonGodX