Add Almalinux advisories
Fix #1201 @ziadhany @TG1999 @keshav-space This is the basic nit to adds Alma Linux advisories into vulnerablecode database, please review it to make further changes.
@ziadhany as this importer uses osv.py importer so shall I add AlmaLinux:8 and AlmaLinux:9 in supported ecosystems in osv.py
@ambuj-1211 yes, you should add it to this PURL_TYPE_BY_OSV_ECOSYSTEM dict.
@ambuj-1211 I looked into your code. Instead of using uppercase, you should use lowercase. then you are going to pass the test.
PURL_TYPE_BY_OSV_ECOSYSTEM = {
....
"almalinux:8": "almalinux:8",
"almalinux:9": "almalinux:9",
}
but you will face another issue. you need to add support for almalinux in univers.
https://github.com/nexB/univers/blob/205d7c48835dfeb6b694c9196728d2b4fa0a011a/src/univers/version_range.py#L1254:L1258
@ziadhany can this be merged ?
@ziadhany can this be merged ?
I still need to review this code
@ambuj-1211 Update the OSV get_affected_purl function to add support for AlmaLinux, just like we did for Maven.
https://github.com/aboutcode-org/vulnerablecode/blob/2888d294b1e1aa0e640faa2e3b1f71434892f24e/vulnerabilities/importers/osv.py#L190
@ziadhany please have a look at it I have made the necessary changes Please have a look on get_advisory URL part am I doing it correctly?
almalinux_logs.txt @ziadhany These are the importer logs.
@TG1999 @ziadhany please have a look at it and please tell me if there are any modifications I need to do or else it is ready to merge.
@ziadhany I have resolved the merge conflicts
@TG1999 @keshav-space @ziadhany please chack if it could be merged now?
@ziadhany @TG1999 gentle reminder please review it, it could be merged now
@ziadhany @TG1999 gentle reminder please review it, it could be merged now
I've been quite busy these past few weeks, but I’ll do my best to review it within this week.
@ziadhany @TG1999 @keshav-space please have a look at it
@ziadhany done the changes
@ambuj-1211 it would also be awesome if you have time to migrate this advisory to work with the importer v2
ex: https://github.com/aboutcode-org/vulnerablecode/blob/main/vulnerabilities/pipelines/v2_importers/oss_fuzz.py