vulnerablecode icon indicating copy to clipboard operation
vulnerablecode copied to clipboard

Published 20 hours ago • verified publisher icon nexB

feature: ui: added progress bar for `vulnerabilities.importers`

Open harsh098 opened this issue 1 year ago • 10 comments

In response to Issue #1376 . I am pushing the changes that add a progress bar to the vulnerabilitites.importers.nvd.NVDImporter

  • Please Review and suggest changes/improvements.
  • I'll replicate these changes to all other importers.

Dependencies Added

  • progress==1.6 allows addition of progress bars to tty consoles.

Screenshots

image

harsh098 avatar Dec 25 '23 10:12 harsh098

@harsh098 thanks! you may need to re-write your commit message, your commit message needs to be imperative, have a look on this https://cbea.ms/git-commit/

TG1999 avatar Dec 25 '23 10:12 TG1999

I have changed commit message please check @TG1999 also shall i propagate this change to all other importers ?

harsh098 avatar Dec 25 '23 13:12 harsh098

@harsh098 the commit message should be Add progress bar to NVDImporter and not Added progress bar to NVDImporter, commit messages should be imperative like a command given to the codebase.

also shall i propagate this change to all other importers ?

Please do!

TG1999 avatar Dec 25 '23 14:12 TG1999

Progress bar has been added to following Importers

  • nvd.NVDImporter
  • github.GitHubAPIImporter
  • gitlab.GitLabAPIImporter
  • npm.NpmImporter
  • pypa.PyPaImporter
  • nginx.NginxImporter
  • pysec.PyPIImporter

Working on rest of importers

harsh098 avatar Dec 27 '23 23:12 harsh098

Added Progress Bar to all importers @TG1999 and @ziadhany please have a look

harsh098 avatar Dec 31 '23 05:12 harsh098

An important thing to consider, The recent workflows failed as dependency progress==1.6 was added to requirements.txt in this commit 8cee434 was not installed by the workflow

@TG1999 and @ziadhany please suggest requisite changes from my end

harsh098 avatar Jan 04 '24 07:01 harsh098

@TG1999 and @ziadhany I forgot to add the dependency progress==1.6 to setup.cfg.
Please rerun the checks. The lastest commit 7f5eb72 fixes this. I apologise for the carelessness

harsh098 avatar Jan 04 '24 14:01 harsh098

@TG1999 and @ziadhany I forgot to add the dependency progress==1.6 to setup.cfg. Please rerun the checks. The lastest commit 7f5eb72 fixes this. I apologise for the carelessness

No worries about carelessness! We all need a helping hand sometimes

ziadhany avatar Jan 05 '24 16:01 ziadhany

Sure @ziadhany , As discussed above this PR addresses the issue #1376 , Are there any further additions required else I'm ma' movin' to other issues I'm researching on to work ?

harsh098 avatar Jan 05 '24 22:01 harsh098

Made the requested changes please have a look @ziadhany and @TG1999

harsh098 avatar Jan 25 '24 12:01 harsh098