vulnerablecode icon indicating copy to clipboard operation
vulnerablecode copied to clipboard

Fix empty version range crash

Open janniclas opened this issue 2 years ago • 4 comments

Fixes https://github.com/nexB/vulnerablecode/issues/1214 . I'm not familiar with either this project nor python, so I'm unsure if this is a good solution. However, it solved the issue I described in the linked ticket. Feedback welcome!

janniclas avatar Jun 21 '23 18:06 janniclas

@janniclas thanks for this PR, if you can add some tests to highlight the issues which are fixed by this PR it would be really helpful.

TG1999 avatar Jun 27 '23 11:06 TG1999

Sure, I'll look into it soonish

janniclas avatar Jun 27 '23 14:06 janniclas

@TG1999 I added a test case based upon the original input I got when running the vulnerabilities.importers.apache_httpd.ApacheHTTPDImporter .

janniclas avatar Jul 14 '23 14:07 janniclas

@janniclas sorry for late reply, please resolve the merge conflicts : )

TG1999 avatar Jan 09 '24 16:01 TG1999

@janniclas I am closing this in favor of https://github.com/aboutcode-org/vulnerablecode/pull/1598 with a fixed history and your commits squashed. Thanks!

pombredanne avatar Sep 23 '24 14:09 pombredanne