scancode-toolkit icon indicating copy to clipboard operation
scancode-toolkit copied to clipboard

Combine license matches in new LicenseDetection

Open AyanSinhaMahapatra opened this issue 3 years ago • 3 comments

See #2878

Tasks

  • [x] Reviewed contribution guidelines
  • [x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x] Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR Run tests locally to check for errors.
  • [x] Commits are in uniquely-named feature branch and has no merge conflicts 📁

AyanSinhaMahapatra avatar May 17 '22 17:05 AyanSinhaMahapatra

@pombredanne @JonoYang This is ready to review!

AyanSinhaMahapatra avatar Jul 12 '22 19:07 AyanSinhaMahapatra

@AyanSinhaMahapatra I'll need a little more time to review this, but I think it's looking good so far. You have some failing CI tests, maybe some other test expectations need to be updated?

JonoYang avatar Jul 13 '22 01:07 JonoYang

@pombredanne All green!

AyanSinhaMahapatra avatar Aug 22 '22 08:08 AyanSinhaMahapatra

@pombredanne this is all ready!

AyanSinhaMahapatra avatar Nov 09 '22 16:11 AyanSinhaMahapatra