scancode-server icon indicating copy to clipboard operation
scancode-server copied to clipboard

Published 20 hours ago • verified publisher icon nexB

Avoid using args and kwargs and remove extra comments.

Open singh1114 opened this issue 7 years ago • 11 comments

Avoid the use of kwargs and args whenever possible.

singh1114 avatar Jun 30 '17 13:06 singh1114

I would like to work on the issue addressed. Also the code must follow the pip8 style guide. I can work on the same.

chetanya-shrimali avatar Oct 03 '17 19:10 chetanya-shrimali

@pombredanne @singh1114 reviews!!

chetanya-shrimali avatar Oct 03 '17 19:10 chetanya-shrimali

@chetanya-shrimali you would need to sync up with @singh1114 on this. This is in his branch

pombredanne avatar Oct 04 '17 05:10 pombredanne

@chetanya-shrimali I think we have taken care of this. Still, if you want to work on this, please explain how are you going to take care of the issue and we will go forward with this.

singh1114 avatar Oct 04 '17 12:10 singh1114

@singh1114 Actually, when I checked the code on pip8 online checker it gave like a variety of errors regarding the format of code. So basically I will reformat the code depending on the number of characters per line, remove extra white spaces, order the comments etc. That's the one thing I would like to do. Other is regarding the update of the readme file. I will open an issue regarding that if it is suitable according to you.

chetanya-shrimali avatar Oct 04 '17 14:10 chetanya-shrimali

@chetanya-shrimali Working in separate issue would be great but we have not encountered issues like whitespaces and all. Please share the results that you have encountered before working on the issues. This will better for you. Otherwise, you will be doing extra efforts.

singh1114 avatar Oct 04 '17 16:10 singh1114

I am attaching some screenshots please have a look at it. @singh1114 screenshot from 2017-10-04 22-32-54 screenshot from 2017-10-04 22-32-29 screenshot from 2017-10-04 22-32-19 screenshot from 2017-10-04 22-32-06 screenshot from 2017-10-04 22-31-53 screenshot from 2017-10-04 22-31-09

chetanya-shrimali avatar Oct 04 '17 17:10 chetanya-shrimali

@chetanya-shrimali We have a limit of 100 characters per line. You can check the .travis.yml file. Still, if you can bring all those to that limit than it would be great. I have to check my code for those issues. travis used to check all those things for us. It never showed us those errors. We need to reconfirm that.

https://travis-ci.org/nexB/scancode-server

singh1114 avatar Oct 05 '17 08:10 singh1114

@singh1114 yes, I can totally do that. I will send the PR soon.

chetanya-shrimali avatar Oct 05 '17 09:10 chetanya-shrimali

@chetanya-shrimali Open a new issue for this. We are going to close this one. In that issue explain everything that you are going to do.

singh1114 avatar Oct 05 '17 16:10 singh1114

@singh1114 Thats perfect. I'll open a new one.

chetanya-shrimali avatar Oct 05 '17 19:10 chetanya-shrimali