scancode-server icon indicating copy to clipboard operation
scancode-server copied to clipboard

Published 20 hours ago • verified publisher icon nexB

Add installation script

Open chetanya-shrimali opened this issue 7 years ago • 16 comments

run using source ./installation.sh It will do following things:

  • Set up the virtual-env scancode-server
  • Activate it
  • Install the requirements

Signed-off-by: chetanya-shrimali [email protected]

chetanya-shrimali avatar Dec 01 '17 07:12 chetanya-shrimali

regarding #106 Plz review @singh1114 @pombredanne

chetanya-shrimali avatar Dec 01 '17 07:12 chetanya-shrimali

scancode3 It can also be written as mentioned above. Actually it is able to execute using git bash on windows but what it will do is install the requirements only. We i will have to add if-else condition and define methods for windows. I can proceed to it if you are ok with it. @pombredanne plz review!!

chetanya-shrimali avatar Dec 01 '17 17:12 chetanya-shrimali

The point is not it executes, but that it pass the tests on Python3. If you can install and pass the tests of https://github.com/nexB/scancode-toolkit on Python3 that would be news to me.

pombredanne avatar Dec 01 '17 17:12 pombredanne

@pombredanne That was the problem we discussed earlier regarding issue #100 in pr #105. And finalized that we have to consider that the user has already installed scancode-toolkit . If we keep in mind that, then there is no further need install scancode-toolkit requirement and it will pass. Plz correct me if i got your point the wrong way 😉

chetanya-shrimali avatar Dec 01 '17 18:12 chetanya-shrimali

scancode-toolkit DOES NOT RUN on Python3, therefore scancode-server that depends on scancode-toolkit CANNOT RUN on Python3, simple.

pombredanne avatar Dec 01 '17 18:12 pombredanne

@pombredanne Pardon, but i changed it to Python 2.7 😓

chetanya-shrimali avatar Dec 01 '17 19:12 chetanya-shrimali

@pombredanne plz review!

chetanya-shrimali avatar Dec 02 '17 15:12 chetanya-shrimali

@pombredanne The error is at line 11 of etc/conf/dev/base.txt. Error message is no module named encodings. Which comes when running install.sh.

chetanya-shrimali avatar Jan 01 '18 18:01 chetanya-shrimali

Thanks. I think you have copied too much from scancode etc/ ..... take only what is strictly needed. Not everything. Also how come there are 17K+ file changed? that does not sound right?

What is media/AnonymousUser ? Why did you commit bin, lib, include and all your local virtual env things? This should never be commited and part of the gitignore (see the gitignore in scancode-toolkit)

pombredanne avatar Jan 04 '18 11:01 pombredanne

Thanks!. what is the etc/configure2.py file in the commits?

pombredanne avatar Jan 19 '18 08:01 pombredanne

And what are the changes you made to the original script?

pombredanne avatar Jan 19 '18 08:01 pombredanne

This is not the final commit :sweat_smile:

chetanya-shrimali avatar Jan 19 '18 08:01 chetanya-shrimali

@pombredanne plz review. I will document it after we reach on a common solution. Thanks!

chetanya-shrimali avatar Jan 20 '18 17:01 chetanya-shrimali

Thanks! Your commit message needs to match our style. It is missing a signed-off-by and the subject should use the imperative style eg

Add installation script #106

Signed-off-by: name <email>

pombredanne avatar Jan 25 '18 13:01 pombredanne

screenshot from 2018-01-27 16-58-32 @pombredanne i have added wincertstore in third-party dir than why does it show error?

chetanya-shrimali avatar Jan 27 '18 11:01 chetanya-shrimali

@pombredanne Its been a while since the pr was opened. @singh1114 plz review.

chetanya-shrimali avatar Feb 12 '18 13:02 chetanya-shrimali