python-inspector icon indicating copy to clipboard operation
python-inspector copied to clipboard

Added option to get resolved packages in a requirements.txt file. Fixes #135

Open arijitde92 opened this issue 2 years ago • 8 comments

Created a new option --resolved-output that finds resolved packages and writes those into the given filename in a typical requirements.txt file format. Also added test test_resolved_cli in test_cli.py.

arijitde92 avatar Nov 25 '23 16:11 arijitde92

I was having an issue rebasing in the previous PR #156 . Hence opened this new PR. It is working as expected. Please check.

arijitde92 avatar Nov 25 '23 16:11 arijitde92

@arijitde92 tests are failing in CI, please check. Thanks!

TG1999 avatar Nov 30 '23 12:11 TG1999

Hi @TG1999 ,

After inspecting the cause of test failure, I found that a few test cases are failing but those test cases are not written by me. Please see screenshots below- macos13 ubuntu22 win2022

As you can see, the same tests are failing for all the OSes and none of them are written by me. Is this happening with other PRs too? Or is this happening somehow because of the code I wrote? As I am not able to find any relation between the code I wrote and the tests that are failing.

Please guide me on this. Thanks.

arijitde92 avatar Dec 01 '23 03:12 arijitde92

@arijitde92 please take a pull from latest main branch, main branch is green :)

TG1999 avatar Dec 01 '23 04:12 TG1999

Hi @TG1999 , I have pulled the latest main branch in my forked repo as you can see the latest commit in the screenshot below. image

But still 1 test is failing in CI as shown in below screenshot. image

arijitde92 avatar Dec 01 '23 05:12 arijitde92

You have to run 'make valid' command to fix formatting errors

TG1999 avatar Dec 01 '23 06:12 TG1999

Hi @TG1999 , checks are now passing. Let me know if anything else is required.

arijitde92 avatar Dec 05 '23 11:12 arijitde92

Hi @TG1999 , I have added unit tests as requested and also edited the code as requested. But now some tests are failing again. Please check in the below screenshot- image

arijitde92 avatar Jan 05 '24 10:01 arijitde92

@arijitde92 too bad you deleted your repo!

pombredanne avatar Oct 25 '24 16:10 pombredanne