perspective-el icon indicating copy to clipboard operation
perspective-el copied to clipboard

tab-bar-mode support

Open isamert opened this issue 4 years ago • 6 comments

I saw that it's mentioned in the README but I would like to know if there is any progress or what do you have in your mind generally. I would also like to contribute for getting this feature if you can give me a few starting points.

isamert avatar Nov 15 '20 22:11 isamert

Cool!

I was actually thinking about that last night, and I think the way Bufler handles tab-bar-mode makes a lot of sense (look at bufler-workspace-tabs.el):

  • make a separate minor mode for it, persp-tabs-mode or another good name — that way it's opt-in for people who (1) don't want it, or (2) use an older version of Emacs
  • advise tab-bar-* functions as needed with :override (not sure how many you need to treat that way; also, please use the new advice system — Perspective uses the old system in several places, but there's no reason to do so for a brand-new feature which relies on Emacs 27 anyway)
  • it feels like it shouldn't be a ton of new code to get working (I haven't studied tab-bar-mode very closely, so not sure about that side of it, but Perspective itself has plenty of helper functions), so I think it can all fit in the current perspective.el source file

I'm pressed for time right now, so by all means give it a try if you want! It's great to have more people familiar with the Perspective code.

gcv avatar Nov 16 '20 01:11 gcv

Hey, I have been using the snippet of code from this comment for a few weeks successfully: https://github.com/Bad-ptr/persp-mode.el/issues/122#issuecomment-1224884651.

LemonBreezes avatar Aug 23 '22 21:08 LemonBreezes

@LemonBreezes: That code wouldn't work directly in Perspective, which has different hooks and parameter setting from persp-mode. Did you adapt it? If so, please post the changes you made. I'd like to give it a try.

gcv avatar Aug 28 '22 13:08 gcv

I came across this on the internet if anyone is interested https://git.sr.ht/~woozong/perspective-tabs, not sure how well known it is.

jasonjckn avatar Jul 11 '24 07:07 jasonjckn

That code looks pretty clean! I haven't tried it myself, but it might be a solid recommendation. Or maybe the author would consider merging that project with Perspective.

gcv avatar Jul 11 '24 21:07 gcv

@gcv I'm daily driving it, so far its been solid

jasonjckn avatar Jul 13 '24 04:07 jasonjckn