Matt Newville

Results 272 comments of Matt Newville

@reneeotten any objections to merging this?

@Tillsten OK, merging this, thanks!

@lellid Thanks - I think this would be a valuable addition. At first glance, I also think it sort of needs some work - I don't think too much. The...

@lellid > I did not confuse height and amplitude. In the provided function, the (primary) height parameter is really the maximum function value, and the amplitude is provided as calculated...

closing, as replaced by #800

@lellid Thanks! This looks like a very good start to me, and I'll try to take a more careful look at it. FWIW, I didn't understand the failures (files were...

@reneeotten Ah, thanks -- "imports out of preferred order"!

@lellid @reneeotten if I understand correctly, we're all in favor of merging this, except for some "not-quite-as-beautiful-as-we-like" `import` statements. Please fix those so we can merge.

@lellid Thanks! I'll plan to merge in a couple of days to give time for final comments or suggestions.

@reneeotten @lellid Yes, let's please have consistent code and docstrings! I think we are happy to merge this, but we kind of need a version we can support, which does...